Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval to enable github pages for node-addon-examples #503

Closed
mhdawson opened this issue May 4, 2020 · 7 comments
Closed

Approval to enable github pages for node-addon-examples #503

mhdawson opened this issue May 4, 2020 · 7 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented May 4, 2020

The N-API team is working to move the workshop material we've done at past conferences into the node-addon-examples repository.

You can read up on more of the details in nodejs/abi-stable-node#391 (comment) if you are interested.

In support of that we'd like to use github pages to deliver the end result. We'd need to enable GitHub pages for that in the repo.

Any objections/concerns about doing that?

@mhdawson
Copy link
Member Author

mhdawson commented May 4, 2020

@nodejs/n-api FYI

@bnb
Copy link
Contributor

bnb commented May 11, 2020

+1 to this but I think in the future as we move forward with refining our website, it would be nice to consolidate and centralize our websites into either subdomains or pages of the official Node.js website to enable the ecosystem to find all our data and useful things rather than having some on subdomains, some on pages of the site, some on GitHub pages, and some on other random services.

@bnb
Copy link
Contributor

bnb commented May 11, 2020

Also: I absolutely respect reaching out to nodejs/admin but I don't think turning on GitHub Pages is something that should require admin-level approval. I know this is at odds with my previous statement, but at present my previous statement is not reality. If a WG, initiative, or team wants to turn things on, I think they should be able to without this level of process. What that looks like should probably be documented, but it feels like both a barrier for projects to get their work done and added maintenance burden for the committees.

@mhdawson
Copy link
Member Author

@bnb,for GitHub pages I agree teams should be able to do that if needed, but I don't think we have that documented anywhere yet.

@sam-github
Copy link
Contributor

There was a org wide audit of wikis from a security perspective, because some of them were turned on, world-writable. It was a fair bit of work, @MylesBorins I think did the work, but it gave me the sense that turning features in a github repo on and off is not just the concern of the people working in that repo, it can have org wide concerns.

The posting of an issue in admin isn't so much of a "asking permission", IMO, its more of a courtesy notification. There are lots of projects sharing the nodejs org, some small amount of coordination/notification of what's going on doesn't seem like an excessive burden to me. We could even make it explicit that it doesn't have to wait for approval, its just for notification.

Or maybe github pages is not in the same category as the wiki, and I'm overly concerned, but above is the source of my concern.

@mhdawson
Copy link
Member Author

I have a tool somewhere which I used to audit the wikis, have always thought we should add that to our automation but never quite got to it.

I'm on the same page as @sam-github its a pretty small ask to open an admin issue and believe the benefits are worth it.

@mhdawson
Copy link
Member Author

This was discussed/raised in both TSC and CommComm meetings and there were no objections in the following week. Considering approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants