Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more subteams under Collaborators #537

Closed
Trott opened this issue Jul 30, 2020 · 7 comments
Closed

more subteams under Collaborators #537

Trott opened this issue Jul 30, 2020 · 7 comments

Comments

@Trott
Copy link
Member

Trott commented Jul 30, 2020

Although I hope the need for subteams is only temporary, I've added net as a subteam and will add http2 once we remove non-collaborators from that team. (The non-collaborators are not active as far as I can tell.) That will enable us to use CODEOWNERS for http2 pull requests. Refs: nodejs/node#34534

@nodejs/tsc @nodejs/community-committee

@mmarchini
Copy link
Contributor

+1 as long as this is a temporary solution.

@gireeshpunathil
Copy link
Member

+1

2 similar comments
@mcollina
Copy link
Member

+1

@ahmadawais
Copy link
Member

+1

@bnb
Copy link
Contributor

bnb commented Aug 4, 2020

+1. If we're blocked on CODEOWNERS by subteams, perhaps it's worth investigating a more permanent solution - I think this is probably a valuable thing to have.

@mmarchini
Copy link
Contributor

FYI this might not be needed once we land nodejs/github-bot#265 (which should be soon)

@Trott
Copy link
Member Author

Trott commented Aug 7, 2020

Done. Will be happy to undo it when the GitHub bot change lands. Until then, closing.

@Trott Trott closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants