Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Can we automate appending changelogs to a release #14

Closed
MylesBorins opened this issue Nov 3, 2017 · 3 comments
Closed

Can we automate appending changelogs to a release #14

MylesBorins opened this issue Nov 3, 2017 · 3 comments
Labels

Comments

@MylesBorins
Copy link

https://github.com/nodejs/node/releases

There is an api for editing a release... so this seems pretty reasonable
https://developer.github.com/v3/repos/releases/#edit-a-release

@Tiriel
Copy link
Contributor

Tiriel commented Nov 3, 2017

That do seem to be a good idea. And most of the required tools are already here I'd say.

This brings me a question.

If I'm not mistaken, GitHub v4 API does not currently support mutating repos and most of their attributes. So, for features like this one, do we mix API versions we call? Do we try to keep some measure of consistency?

@joyeecheung
Copy link
Member

joyeecheung commented Nov 3, 2017

@Tiriel I'd say when we are not in a monorepo, the best thing to do is go with the API that can meet most of your needs (or the primary one), and add another if the features are lacking. The GraphQL API does support mutations, but from a quick search in the explorer I don't think release mutations are supported. In this case the v3 API seems to be the one to go with.

@Tiriel
Copy link
Contributor

Tiriel commented Nov 3, 2017

@joyeecheung Yup, that was my point. I searched through the v4 API reference and didn't see release mutations.

Anyway, I'm ok with this rule. Consistency in monorepo, and what we need elsewhere!
I guess then this could be implemented!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants