Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] cmake build job #1003

Closed
bnoordhuis opened this issue Nov 20, 2017 · 12 comments
Closed

[request] cmake build job #1003

bnoordhuis opened this issue Nov 20, 2017 · 12 comments

Comments

@bnoordhuis
Copy link
Member

I'd like to start testing my cmake branch: https://github.com/bnoordhuis/io.js/tree/cmake

To that end, it would be helpful to have a node-test-commit-like job with the difference that it should run ./configure --cmake=/path/to/cmake.

Cmake version: I'm testing with 3.9 but anything >= 3.6 should be good enough.

Platform matrix: bigger is better but fast - especially in the initial phase - I'd appreciate the most. Linux, Windows, MacOS to start out with?

cc @gibfahn

@bnoordhuis
Copy link
Member Author

@gibfahn Just wondering if you had time to look at this. No pressure, on my desk by 1600 is fine.

@gibfahn
Copy link
Member

gibfahn commented Nov 27, 2017

I'll trade you it for a rebased/revived nodejs/node#12231

@bnoordhuis
Copy link
Member Author

You drive a hard bargain... I'll see what I can do.

@bnoordhuis
Copy link
Member Author

@gibfahn Any news?

@rvagg
Copy link
Member

rvagg commented Dec 28, 2017

@bnoordhuis I could quickly spin one up for you using Docker but you'd only get Linux then. We do this with Alpine and the miscellaneous quirky build types in node-test-commit-linux-linked by just adding and deploying Dockerfiles. We could get >1 distro covered it if helps. Would that be good enough to get started or is there not much point unless you have the full suite of OSs covered?

@rvagg
Copy link
Member

rvagg commented Dec 28, 2017

On second thought, it's probably not an ideal setup to throw it into a Docker container. Maybe we just give you a dedicated Jenkins job with write permissions for you so you can attach arbitrary nodes to and script them up as necessary to test it out.

@bnoordhuis
Copy link
Member Author

Yes, please. I'm well-stocked on the Linux and MacOS front but being able to test Windows, AIX, etc. would be a big boon.

@gibfahn
Copy link
Member

gibfahn commented Jan 3, 2018

Okay, I've done the first part of this, which is changing node-test-commit to allow you to pass a custom set of CONFIG_FLAGS.

You can call it like this: https://ci.nodejs.org/job/node-test-commit/15212/

image

Now I just have to work out how to get cmake installed and in the path on all the machines (including AIX...). I guess it's a good chance to test the ansible scripts...

@gibfahn
Copy link
Member

gibfahn commented Jan 3, 2018

BTW @bnoordhuis , it'd be nice if when cmake wasn't in the path the error specifically mentioned which file wasn't found (in this case cmake).

Traceback (most recent call last):
  File "./configure", line 1562, in <module>
    configure_cmake(output)
  File "./configure", line 1439, in configure_cmake
    sys.exit(subprocess.Popen(cmake_args, cwd='out.cmake').wait())
  File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
make: *** [build-ci] Error 1

@maclover7
Copy link
Contributor

ping @bnoordhuis @gibfahn -- is this still needed?

@bnoordhuis
Copy link
Member Author

Yes.

@bnoordhuis
Copy link
Member Author

I can get by with GH Actions for now so I'll close this out, cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants