Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.11 x64 MSI is corrupt #1211

Closed
refack opened this issue Apr 5, 2018 · 5 comments
Closed

9.11 x64 MSI is corrupt #1211

refack opened this issue Apr 5, 2018 · 5 comments

Comments

@refack
Copy link
Contributor

refack commented Apr 5, 2018

Ref: nodejs/node#19816

The file seems truncated (headers look visually similar), but I couldn't find a tool that would even attempt to extract it.
File does match it's published SHA256 - 27ca07f3eeac71902f6daec28e763fe1c4c19e112da89d5d226e95b4750d6961 but is missing the internal signature structure.

  • x86 MSI is fine
  • last two x64 nightly MSIs are fine
  • 9.10.1 x64 MSI is fine

I vote to remove from site, and recommend workaround.

/CC @nodejs/release

@MylesBorins
Copy link
Member

I don't think we should be removing assets that we have published shasums for. I'm publishing a new release, and I think we just leave the old one as is. Thoughts?

nodejs/node#19818

@rvagg
Copy link
Member

rvagg commented Apr 5, 2018

https://ci-release.nodejs.org/job/iojs+release/3276/nodes=vs2015-x64/console

scp: nodejs/release/v9.11.0//node-v9.11.0-x64.msi: No space left on device

New releases make sense but don't do it just yet .. we need to sort this space problem out! #1202

@rvagg
Copy link
Member

rvagg commented Apr 5, 2018

the logs don't show it unfortunately but I'm assuming that ssh node-www touch .../node-v9.11.0-x64.msi.done was performed after the scp failed. Not what I would have expected.

I think we're going to need a @nodejs/platform-windows expert to have a look at https://github.com/nodejs/node/blob/master/vcbuild.bat#L371 and come up with a strategy to make the batch file fail if one of these commands fail, the whole point of the .done is to signal that the file upload is complete.

@MylesBorins
Copy link
Member

fixed in 9.11.1

@refack
Copy link
Contributor Author

refack commented Apr 5, 2018

I'm looking into the vcbuild failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants