Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: macOS 10.10 can't compile V8 6.8 #1415

Closed
refack opened this issue Jul 25, 2018 · 2 comments
Closed

release: macOS 10.10 can't compile V8 6.8 #1415

refack opened this issue Jul 25, 2018 · 2 comments

Comments

@refack
Copy link
Contributor

refack commented Jul 25, 2018

Refs: #1358 (comment)
Refs: #1409
Refs: nodejs/node#21079
Refs: #1264

V8 6.8 requires Xcode 8.x or higher but unfortunately Xcode 8.x is not supported on macOS 10.10

We only have a macOS 10.10 release machine, so ATM we can't release with V8 6.8.
The crux is the use on thread_local modifier for 2 variables used by torque which is a codegen tool used by the build process (no thread_local usage in the actual V8 code).
https://github.com/targos/node/blob/716948b9de79bbd327e9e496e4db8fc07e82b742/deps/v8/src/torque/contextual.h#L52-L57

We have a few options:

  1. Upgrade the release machine
  2. Patch the torque code (maybe as per https://stackoverflow.com/a/25393790/27955)
  3. Cache the generated code (AFAICT it's identical when generated on macOS 10.10 and 10.11), and tweak the gyp files

/CC @nodejs/v8-update @nodejs/build-infra (specifical @targos and @rvagg)

@targos
Copy link
Member

targos commented Jul 25, 2018

There is also option 4: add a new release machine.
See #1391

@refack
Copy link
Contributor Author

refack commented Jul 31, 2018

Closing in favor of #1391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants