Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem sending coverity report #3343

Closed
targos opened this issue May 5, 2023 · 18 comments
Closed

Problem sending coverity report #3343

targos opened this issue May 5, 2023 · 18 comments

Comments

@targos
Copy link
Member

targos commented May 5, 2023

https://ci.nodejs.org/view/All/job/node-daily-coverity/2626/console

+ VERSION=v21.0.0-pre-76ae7be78d
+ FILE=nodejs-v21.0.0-pre-76ae7be78d.tar.gz
+ tar -czf nodejs-v21.0.0-pre-76ae7be78d.tar.gz cov-int
+ set +x
<html>
<head><title>413 Request Entity Too Large</title></head>
<body>
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>cloudflare</center>
</body>
</html>
+ rm -rf nodejs-v21.0.0-pre-76ae7be78d.tar.gz cov-int
@richardlau
Copy link
Member

Not sure how big our tarball is currently, but other projects have run into the same issue within the last month:

We may need to contact support.

Separately we might also want to make these failures fail the build.

@richardlau richardlau mentioned this issue May 15, 2023
Closed
@mhdawson
Copy link
Member

Send this email to scan-admin@coverity.com based on request to do that in the issues @richardlau mentioned:

The Node.js project is getting errors trying to upload scan results:
+ ./node --version
+ git rev-parse --short HEAD
+ VERSION=v21.0.0-pre-f36461dc6a
+ FILE=nodejs-v21.0.0-pre-f36461dc6a.tar.gz
+ tar -czf nodejs-v21.0.0-pre-f36461dc6a.tar.gz cov-int
+ set +x
<html>
<head><title>413 Request Entity Too Large</title></head>
<body>
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>cloudflare</center>
</body>
</html>
More details in https://github.com/nodejs/build/issues/3343.

Seems like other projects had the same issue and were asked to reach out to this email to get the upload size limit increased. 

Can you do that for the Node.js project?

@mhdawson
Copy link
Member

Emailed again as follow up.

@mhdawson
Copy link
Member

Also trying to register in the Synopsys community to be able to report there as well.

@mhdawson
Copy link
Member

Created this case - https://community.synopsys.com/s/case/500Hr00001VqtfjIAB/coverity-scan-uploads-failing

@mhdawson
Copy link
Member

From coverity team

Hi Michael,

We will have the API in place by the end of next week. We will keep you posted.

Regards,

Alex Johnson

@mhdawson
Copy link
Member

URL to upload manually - https://scan.coverity.com/projects/node/builds/new

@mhdawson
Copy link
Member

Correct URL to upload - https://scan.coverity.com/projects/node-js/builds/new

@mhdawson
Copy link
Member

Uploaded a build manually last week, and uploading one today

@richardlau
Copy link
Member

There's a new API on https://scan.coverity.com/projects/node-js/builds/new?tab=url but it looks like we'd need to make the tarball available on a publicly accessible URL to use it.

@richardlau
Copy link
Member

Ah there's also more instructions on https://scan.coverity.com/projects/node-js/builds/new in the section

  1. If the build size exceeds 500MB, upload limits come into effect.
    To upload larger builds, please do the following:

@richardlau richardlau mentioned this issue Jun 22, 2023
Merged
@richardlau
Copy link
Member

richardlau commented Jun 22, 2023 •
edited

I've edited the job to use the new API documented on https://scan.coverity.com/projects/node-js/builds/new. This requires adding jq to the jenkins-workspace machines, which I've added to the Ansible scripts in #3397.

The job edits for using the new API are recorded in

Kicked off a new build: https://ci.nodejs.org/job/node-daily-coverity/2680/

@richardlau
Copy link
Member

Kicked off a new build: https://ci.nodejs.org/job/node-daily-coverity/2680/

This looks like it has worked and the scan and analysis for v21.0.0-pre-b352e0c36a is on https://scan.coverity.com/projects/node-js.

Since we're limited to one build submission per 24 hours, the next scheduled run of https://ci.nodejs.org/job/node-daily-coverity/ is expected to fail to upload as it will occur within the 24 hour period.

@richardlau
Copy link
Member

richardlau commented Jun 23, 2023 •
edited

Since we're limited to one build submission per 24 hours, the next scheduled run of https://ci.nodejs.org/job/node-daily-coverity/ is expected to fail to upload as it will occur within the 24 hour period.

https://ci.nodejs.org/job/node-daily-coverity/2681/console failed as expected (which is good because previously the failed uploads were not failing the build)

The build submission quota for this project has been reached. Next submission permitted on or after 2023-Jun-23  7:56 PM UTC
parse error: Invalid numeric literal at line 1, column 4
Build step 'Execute shell' marked build as failure

Let's check the next scheduled build succeeds, and then we can probably close this out.

richardlau added a commit that referenced this issue Jun 23, 2023
@richardlau
ansible: install jq on jenkins-workspace (#3397)
0492f6e 
The new upload method for Coverity requires parsing a JSON response
from the new Coverity API.

Refs: #3343
@mhdawson
Copy link
Member

I received an email saying the new API was ready and we'd have to update the endpoint we use. Interestingly the scan on the 22nd passed without me doing anything. The scan for the 23rd failed with this message:

The build submission quota for this project has been reached. Next submission permitted on or after 2023-Jun-23  7:56 PM UTC
parse error: Invalid numeric literal at line 1, column 4
Build step 'Execute shell' marked build as failure
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILURE

I plan to look at the new instructions for uploading next week to see how easy it will be to update.

@richardlau
Copy link
Member

@mhdawson See my posts above yours -- I've switched the CI job to use the new API which is how the scan from the 22nd got uploaded.

@mhdawson
Copy link
Member

ah ok, I just got the scan email but did not read through the history. Great to see you have already adjusted it to use the new API, explains why it started working :)

@richardlau
Copy link
Member

Builds over the weekend look good and https://scan.coverity.com/projects/node-js is showing the build from https://ci.nodejs.org/job/node-daily-coverity/2684/.

We're also now getting emails through to the build alias when the scan completes (i.e. after the upload is done and analyzed). This is via the email data to the initial curl POST invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @richardlau @mhdawson