ansible: install devtoolset-8 on centos7 #2262
Conversation
|
I wish I could move this back to draft... I'm finding its a bit WIP as I work through the various rhel/centos systems and need to patch the ansible. |
| [ /^centos[67]-(arm)?(64|32)-gcc48/,anyType, gte(10) ], | ||
| [ /^centos[67]-(arm)?(64|32)-gcc6/, anyType, lt(10) ], |
There was a problem hiding this comment.
Just added the ^ for consistency.
There was a problem hiding this comment.
ok, but are you sure there are no labels used anywhere with some cruft in front? I don't think there but we've been caught with overly strict regexes in the past (in select-compler.sh trying to identify all the benchmark machines iirc was the latest).
| [ /^centos[67]-(arm)?(64|32)-gcc6/, anyType, gte(14) ], // 14.x: gcc6 builds stop | ||
| [ /^centos7-(arm)?(64)-gcc8/, anyType, lt(14) ], // 14.x: gcc8 builds start |
There was a problem hiding this comment.
Here we are stopping using one set of labels after 14.x, and switching to a new set. I think its intentional to do anyType, its not intended that we test with gcc6/aka devtoolset-6, is it?
There was a problem hiding this comment.
ack
Yes let's just leave it as a clean break even for testing. We can expand later if we see a need but we had had a problem with exploding permutation complexity just because we can in the past, and let's try to resist that urge.
There was a problem hiding this comment.
I assume we still have some linux platforms building/testing on gcc6 thought right ?
There was a problem hiding this comment.
For 14.x, specifically? I don't know. For earlier releases, yes.
If you want I can take can try to find the compiler levels for all machines 14.x are tested on, but I spent 10 minutes looking, and its not documented anywhere AFAICT. Figuring it out would take a combination of finding all linux builds in https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-master/1899/, reading the console logs, then sshing into the machines (if they don't explicitly set the version, many don't, I have to look... for example ubuntu 18.04 is using gcc7, I just checked). If nodejs/node#32715 (comment) lands, then the ssh won't be needed, just reading the top of all the console logs.
AIX builds on gcc6.
There was a problem hiding this comment.
From the CI for nodejs/node#32715 (https://ci.nodejs.org/job/node-test-pull-request/30565/) the following Linux jobs are using gcc6:
- debian9-64 is using 6.3.0
- ubuntu1604-64 is using 6.5.0
|
@nodejs/build @nodejs/releasers Please take a careful look at this, I think I got it all right, see checklist in #2242. Some of the builds were kicked off recently as repeats of last night to make sure I build with default configs selected, so are ongoing, but went well last night. I did builds on my job-forks for 12.x (to make sure I didn't break existing releases) and master (for 14.x). I'm trying to be careful, and the changes aren't huge, but there is a non-zero chance of breaking things. Once I merge, I'll kick off builds for multiple branches in ci and i-release (obviously not real release builds, just test runs). releasers: Is there any more releases planned for the next few days that this could impact? build-wg and anyone: this reflects the 14.x plan? PTAL |
When trying to ansible test-rackspace-centos7-x64-1 I found that it can't install git, because that's 1.8, and it has git216 installed. So, git can't be shared by all centos7 platforms, the name differs, move into a more specific package list.
It isn't there now, so probably doesn't have to be, and it doesn't seem to be available, so move it out of the common packages.
In addition, configuration changes were made in CI.
When trying to ansible test-rackspace-centos7-x64-1 I found that it can't install git, because that's 1.8, and it has git216 installed. So, git can't be shared by all centos7 platforms, the name differs, move into a more specific package list. PR-URL: #2262
It isn't there now, so probably doesn't have to be, and it doesn't seem to be available, so move it out of the common packages. PR-URL: #2262
In addition, configuration changes were made in CI. PR-URL: #2262
|
Landed in a6dd558...a042232 |
nodejs#2262 mistakenly added a duplicated case that prevented the previously existing logic from being executed. Merge the two centos cases for ppcle Linux. Signed-off-by: Richard Lau <riclau@uk.ibm.com>
#2262 mistakenly added a duplicated case that prevented the previously existing logic from being executed. Merge the two centos cases for ppcle Linux. Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Refs: #2242