Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe how to revert sec lockout #2336

Merged
merged 3 commits into from Jun 3, 2020
Merged

doc: describe how to revert sec lockout #2336

merged 3 commits into from Jun 3, 2020

Conversation

sam-github
Copy link
Contributor

No description provided.

@sam-github
Copy link
Contributor Author

@richardlau WDYT, does this describe what you did? I think we both did it at the same time.

@richardlau
Copy link
Member

richardlau commented Jun 3, 2020

The additional text LGTM (I also didn't see a way to restore the old permissions from the history view). We might need to have a discussion on what the "normal" permissions are supposed to be. I was paranoid and took a picture of the permissions prior to editing them for the lockdown. They looked as follows and you'll note there's several entries that weren't in the picture in the guide:

image

I did put all these back, but unfortunately it looks like because we both did it at the same time the changes I made were immediately overwritten by the ones you did (no blame there, the guide is either inaccurate or we'd somehow accrued a bunch of permissions that shouldn't have been there).

There was at least one previous attempt to update the guide which stalled out: #1450

@sam-github
Copy link
Contributor Author

@richardlau I pushed your screenshot update into this PR

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of wish I'd noticed before that I'd cut off the headers in the screen snip.

@sam-github sam-github merged commit dd9ead3 into nodejs:master Jun 3, 2020
@sam-github sam-github deleted the jenkins-sec-after branch June 3, 2020 18:23
@sam-github
Copy link
Contributor Author

I retook the screenshot, with all the headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants