Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible,docker: install Python 3.9 in Stretch RPi's #2606

Merged
merged 3 commits into from Apr 19, 2021

Conversation

targos
Copy link
Member

@targos targos commented Apr 3, 2021

This also changes the base image to balenalib/rpi-raspbian:stretch.
The old one is no longer maintained.

This also changes the base image to balenalib/rpi-raspbian:stretch.
The old one is no longer maintained.
@targos
Copy link
Member Author

targos commented Apr 3, 2021

# docker run --rm -it --entrypoint /bin/bash fc8e702cae1a
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm/v7) and no specific platform was requested
iojs@8eb9a538c78b:/$ python3
Python 3.9.3 (default, Apr  3 2021, 18:56:26)
[GCC 6.3.0 20170516] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

@targos
Copy link
Member Author

targos commented Apr 3, 2021

Refs: #2507

@targos
Copy link
Member Author

targos commented Apr 5, 2021

@rvagg, @richardlau do you think this is an acceptable change? Python 3 is installed as python3, python still resolves to the default Python 2.
The downside is that it takes some time to compile. I forgot to measure how long but I think it was less than an hour.

@targos
Copy link
Member Author

targos commented Apr 5, 2021

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm/v7) and no specific platform was requested

What about this warning? Are we supposed to ignore it or did I do something wrong?

@rvagg
Copy link
Member

rvagg commented Apr 5, 2021

Currently doing some major work on the Pi3's and I'm using this branch, but also skipping jessie in the build. Will be able to report back on how it goes soon.

@rvagg
Copy link
Member

rvagg commented Apr 5, 2021

@targos can you also add this to your PR please? This is running live now on the 3's and I've just confirmed in node-test-binary-arm-12+ that only stretch is run these days so Jessie isn't even needed. Just running some confirmation runs to make sure it's stable before I give a 👍 here.

ansible/roles/jenkins-worker/vars/main.yml:

       { name: 'jessie', template: 'rpi_jessie.Dockerfile.j2' }
     ],
     armv7l: [
-      { name: 'jessie', template: 'rpi_jessie.Dockerfile.j2' },
       { name: 'stretch', template: 'rpi_stretch.Dockerfile.j2' }
     ],
     arm64: [
-      { name: 'jessie', template: 'rpi_jessie.Dockerfile.j2' },
       { name: 'stretch', template: 'rpi_stretch.Dockerfile.j2' }
     ]
   }

@rvagg
Copy link
Member

rvagg commented Apr 6, 2021

the 3's are looking good with this, I'll roll it out to the 2's but they'll take longer to build

@targos
Copy link
Member Author

targos commented Apr 6, 2021

I'm on holiday this week, feel free to update my branch

@richardlau
Copy link
Member

the 3's are looking good with this, I'll roll it out to the 2's but they'll take longer to build

@rvagg Any outlook on this? 16 is due out next week and nodejs/node#37764 and nodejs/node#36691 are blocked on this.

@richardlau
Copy link
Member

I've run the worker playbook against the Pi 2's and I think this has deployed on all of them except the two unreachable hosts test-requireio_joeyvandijk-debian10-armv7l_pi2-1 and test-requireio_louiscntr-debian10-armv7l_pi2-1.

Started a CI run for nodejs/node#37764: https://ci.nodejs.org/job/node-test-pull-request/37473/

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cclauss
Copy link
Contributor

cclauss commented Apr 18, 2021

Any outlook on this?

@richardlau
Copy link
Member

Any outlook on this?

It’s deployed but I’m holding off merging in case there’s something I’ve missed with the Pi set up. cc @rvagg

@rvagg
Copy link
Member

rvagg commented Apr 19, 2021

it's deployed on the 3's, not the 2's, but it seems like I need to re-do the 3's from scratch anyway #2365
but, this worked for me, I'm good with merging it and tweaking later

@richardlau
Copy link
Member

it's deployed on the 3's, not the 2's, but it seems like I need to re-do the 3's from scratch anyway #2365
but, this worked for me, I'm good with merging it and tweaking later

@rvagg I deployed it on the 2's (at least the reachable ones): #2606 (comment). I'll merge this then.

@richardlau richardlau merged commit 79d8678 into nodejs:master Apr 19, 2021
@targos targos deleted the update-python-stretch branch April 19, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants