jenkins: temporarily exclude win32 for Node.js 18 #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
targos
approved these changes
Apr 11, 2022
24 tasks
richardlau
added a commit
that referenced
this pull request
Apr 14, 2022
Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18. Introduce a new `gteLt` closure for exclusions between two versions. Refs: nodejs/node#42690 Refs: nodejs/node#42740 (comment) Refs: #2921
richardlau
added a commit
that referenced
this pull request
Apr 19, 2022
Run 32-bit Windows CI for Node.js 19 but skip (for now) on Node.js 18. Introduce a new `gteLt` closure for exclusions between two versions. Refs: nodejs/node#42690 Refs: nodejs/node#42740 (comment) Refs: #2921
richardlau
added a commit
to richardlau/build
that referenced
this pull request
May 31, 2022
This reverts commit abf9ebd.
richardlau
added a commit
that referenced
this pull request
May 31, 2022
This reverts commit abf9ebd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#42666
Refs: nodejs/node#42543 (comment)
cc @nodejs/platform-windows @nodejs/build @nodejs/v8-update
This is the quick way to land nodejs/node#42657 and get a clean CI for Node.js 18. The plan will be to reverse this as soon as possible when we're able to pick up a stable V8 which compiles on 32-bit Windows.