Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: update checked html page #3230

Merged
merged 3 commits into from
Mar 21, 2023
Merged

www: update checked html page #3230

merged 3 commits into from
Mar 21, 2023

Conversation

richardlau
Copy link
Member

After the switch to Next.js, /home/www/nodejs/en/index.html no longer exists.

After the switch to Next.js, `/home/www/nodejs/en/index.html` no longer exists.
@richardlau

This comment was marked as outdated.

@richardlau
Copy link
Member Author

Since /home/www/nodejs/en/index.html no longer exists,

[ /home/dist/nodejs/release/index.json -nt /home/www/nodejs/en/index.html ]

was always true and the website was being rebuilt every 5 minutes (check-build-site.sh is run every 5 mins on a cron timer). Which is likely to be contributing to the server instability (cpu/mem usage and more frequent CDN purges).

@domdomegg
Copy link

This script isn't used for iojs anymore since that got turned into just a redirect. We can probably just strip that out to make this much simpler.

Copy link

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now. Can remove iojs bits as a separate PR.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 04aa8b9 into main Mar 21, 2023
@richardlau richardlau deleted the check-build-site.sh branch March 21, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants