ansible: move Coverity Scan build tool install #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use gcc 12 to compile h2load as latest nghttp2 does not compile with gcc 11. Refs: nghttp2/nghttp2#2194
Install the Coverity Scan build tool on the `benchmark` machines instead of the `jenkins-workspace` machines. Refs: nodejs#3723
|
I'll swap the node-daily-coverity job to run on the benchmark machines and run some test builds. They will fail to upload the scan (since we are limited to one submission per day) but we should be able to check that the build completes up to the upload step. |
targos
approved these changes
Jun 5, 2024
|
https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-coverity/3037/ looks okay, apart from the expected failure to submit/upload due to the one per day limit. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install the Coverity Scan build tool on the
benchmarkmachines instead of thejenkins-workspacemachines.Refs: #3723
To run the playbook I also needed to patch the
benchmarkrole to use gcc 12 instead of the default gcc 11 to compileh2loadfromnghttp2due to nghttp2/nghttp2#2194.