Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pull request message improvements #6

Open
targos opened this issue May 15, 2022 · 0 comments
Open

Initial pull request message improvements #6

targos opened this issue May 15, 2022 · 0 comments

Comments

@targos
Copy link
Member

targos commented May 15, 2022

I'm not sure this project is the right place to open the issue. Sorry if the message is generated elsewhere.
I'm taking this message as a reference: nodejs/TSC#1225 (comment)

  1. When I voted, I didn't think that a readable version of the voting options was available in the first commit, so I thought that I had to start the process to know what the options were. My suggestion would be to add the list of options to the pull request description, before listing the different voting methods.
  2. That may be more difficult to handle here, but I think it's important to make sure that all people how are allowed to vote are aware that a vote started. In the case of the Node.js TSC, I would add a ping of the @nodejs/tsc GitHub team to the pull request description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant