Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote on parseArgs "home" module #1225

Merged
merged 22 commits into from May 25, 2022
Merged

Vote on parseArgs "home" module #1225

merged 22 commits into from May 25, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 5, 2022

Use one of the following methods to case a vote (or abstain):

Vote using npx+gh (requires Node.js 16+, and git)

Requires gh (GitHub CLI tool) to be installed, and logged in to your GitHub account.

npx --package=@aduh95/caritat voteOnGitHub https://github.com/nodejs/TSC/pull/1225

If you want to abstain, you can use the --abstain flag (it will create a ballot with all the scores set to 0):

npx --package=@aduh95/caritat voteOnGitHub https://github.com/nodejs/TSC/pull/1225 --abstain
Vote using npx (requires Node.js 16+, and git)
# Cloning and pushing using SSH
npx --package=@aduh95/caritat voteUsingGit -r git@github.com:nodejs/TSC.git \
  -b vote-parseArgs-home-module -p votes/parseArgs-home-module

# Cloning and pushing using HTTPS
USERNAME=<your-github-handle> \
npx --package=@aduh95/caritat voteUsingGit -r https://$USERNAME@github.com/nodejs/TSC.git \
  -b vote-parseArgs-home-module -p votes/parseArgs-home-module --handle "$USERNAME"

# To abstain, use the flag --abstain
npx --package=@aduh95/caritat voteUsingGit -r git@github.com:nodejs/TSC.git \
  -b vote-parseArgs-home-module -p votes/parseArgs-home-module --abstain
Vote using sh (requires git, and OpenSSL CLI)

Caution: LibreSSL CLI is not compatible, please use OpenSSL 1.1.1+.

curl -LOJ https://github.com/stduhpf/caritat/raw/HEAD/sh/voteUsingGit.sh
curl -LOJ https://github.com/stduhpf/caritat/raw/HEAD/sh/encryptBallot.sh
chmod +x encryptBallot.sh
sh ./voteUsingGit.sh \
  <your-github-handle> \
  git@github.com:nodejs/TSC.git \
  vote-parseArgs-home-module \
  votes/parseArgs-home-module
rm encryptBallot.sh
rm voteUsingGit.sh
Vote using PowerShell (requires git, and OpenSSL CLI)

Caution: LibreSSL CLI is not compatible, please use OpenSSL 1.1.1+.

Set-ExecutionPolicy Bypass -Scope Process -Force
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072
$tmpFile = $(New-TemporaryFile | Rename-Item -NewName { $_ -replace 'tmp$', 'ps1'} -PassThru)
$encryptBallot = $tmpFile -replace '\\[^\\]+$','\encryptBallot.ps1'
((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/stduhpf/caritat/HEAD/sh/voteUsingGit.ps1')) | Out-File -FilePath $tmpFile
((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/stduhpf/caritat/HEAD/sh/encryptBallot.ps1')) | Out-File -FilePath $encryptBallot
& $tmpFile `
  <your-github-handle> `
  git@github.com:nodejs/TSC.git `
  vote-parseArgs-home-module `
  votes/parseArgs-home-module
Remove-Item $encryptBallot
Remove-Item $tmpFile
Vote using the web
  1. Fill in the ballot at https://stduhpf.github.io/caritat/#https://github.com/nodejs/TSC/pull/1225. It will copy the encrypted ballot to your clipboard.
  2. Paste the encrypted ballot in https://github.com/nodejs/TSC/new/vote-parseArgs-home-module/votes/parseArgs-home-module. It's recommended to use <your-github-handle>.json for the file name.
  3. Commit directly to the vote-parseArgs-home-module branch.

To abstain, set all scores to 0 before encrypting the ballot.

The counting will be done using the Condorcet method. The vote will close in two weeks at the latest.

Fixes: #1224

@aduh95 aduh95 changed the title Vote parse args home module Vote on parseArgs "home" module May 5, 2022
@targos
Copy link
Member

targos commented May 15, 2022

@nodejs/tsc

@aduh95
Copy link
Contributor Author

aduh95 commented May 18, 2022

Election results

Subject: Which core module should "host" the args parser API?
End date: 2022-05-18T15:58:37.930Z
Participation: 80%

Results

Winning candidate: node:util

Table of results

Candidate Number of won duels
node:util 1
node:process 0

Voting data

Participants:

Private key to decrypt ballots
-----BEGIN PRIVATE KEY-----
MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQDBceVmOGf4QKcJ
nuvJf/ngg6TOOWpRiv/zZ7v9AxYw8fZ3EOeLSYoWDs3AqFS/EcsTPFdpBVjwxWSy
ttVR9ThNkodEnhsuQ+8xeG77rKa+iAtYSijB1nI4KqZSqUU2H+uf0eIYSj3vXR2c
iBnH3MHARVHeJC+EDjfZpiHc6unqvaGPDZO3ErrVzpGByHl4ZHfevpfKnF6qUF9r
GmQEU/R0e3lddLr6fFPnp+lkizyzFSfEa7MGdYIo3u1UZc3onjWw0a3zZmBs8TwO
Ks+3/4S21JqQ4Fv8TrFNUKs5b6snBLFwkUR9h50BE2KvhYxXpCIMpFCriVKp+fps
KF2qdUFlAgMBAAECggEAHHjVGNyIgQOTEllvvvK1JpR5t1jAC0x4K61DABRqOb4D
VrcIPXoPdvuq0QZ1osHNsAEbpHuDAb0r+xnp/+wl41UDz9etjHu3QwLE4wogaL7B
XLddlFop6ZZtcJE1fKfqGFXd/1E+GHMOHrHxiXc2lUQerqGI1Nj643AOX+O7li8d
fAziCDtar+DUpchTJ6ypBRqEjhlJL2j4P1Ngp2kzNATX8InbR7tam6PzZv0p9yit
xjGdj5MB8emMPRwlrd/IMReKTuzBS4KaAMfeHUStrRs3VKki4/P27/55giM58wpu
qNyQF4felrAXMbuOTLAKSL/na81ELVC8t4qq7juiQQKBgQDoiXATH8e8tIzrajTl
rMQO/CaiA/8pfvkzjERSb39Bg1M/eTUJePOIr319snTwrqbnk+p4kmEA0+9WQs6x
gZ3X9j6toqvW/fvNrFu5OThK6gc4Yi4F5MhIYByA7S2MxaUl8ZsS17WdHrM4Xz+e
Sjxtbe67XNn4GVMRV0AgnlizfQKBgQDU9rC296XJVjBiWNZ8LN9KNjSNWmPmwM6O
HKFPBqLXbZK0JiAQKCHq7yrRUSZaw8Nq8q8YWFuXOp9HD6tQJ1+/UWD2shmzn8tM
o+VN4Spnxap/wCx7pJYY/Z7rmGg6IjL3bJ3zivae8n5e0DoKElUaI503Jy0LnwMb
mwBFTcFaCQKBgFtt7osWa8pekync0H+dtljN+8KoH6OJMSJ7fEGNZVO09v52Acx/
qgGMPqM1j5Uylp1nI0HVDB7vNaONEQfqFs3bHDnZRAd8RY1Qv5/MR73s1nns4Hug
wL70S0DGAKrg61ZH8Nkvx1DHyV/Y04LBXZEJMFyq3WkXS/n9fFFW8TlhAoGAXFkZ
Kk5beuJAGvWRFMnUjfbRdRZkSdUD/QYXQRCMnsRqIGqD7t2oT5skwx3gdu17GS5h
lToDhaGrHgKCdECOuYTNekyi7ox1eSd9MPdaDyPdGoa4A2nMmMuqFVnCoKrh1P8p
w0lYRna7K9w5vtJSSwJ0k00OsIJks5zUUjk0hhkCgYEAsi/poQhpEoMWZnXgrAj/
raHTpHVy6pXXJAvH/b67peliZNr5n2oxxJysnMcILgOjdLBybEwYdES6wmoZnfYV
ZwT9/mVI89Y42R4Y/Xtl0io0WL4VHhq/Ma1rU5mHNG3IT+mcmUx7kwM8M2ThQEEc
+eXiycnPqHajk3r9ZLuqetA=
-----END PRIVATE KEY-----

Footnotes

  1. Voted for node:process.

  2. Abstained.

  3. Voted for node:util.

  4. Abstained.

  5. Voted for node:process.

  6. Abstained.

  7. Voted for node:util.

  8. Voted for node:util.

  9. Voted for node:util.

  10. Voted for node:util.

  11. Voted for node:process.

  12. Abstained.

  13. Voted for node:util.

  14. Abstained.

  15. Voted for node:util.

  16. Voted for node:process.

@ljharb
Copy link
Member

ljharb commented May 18, 2022

aww, boo

@Trott
Copy link
Member

Trott commented May 18, 2022

I don't think this meets our governance requirements.

20 members
5 abstentions

Votes needed for a decision: 8 ((20 - 5) / 2)

Votes for each item: 7 - 4

We need 2 more explicit abstentions OR 1 more vote for node:util OR 4 more votes for node:process.

@bcoe
Copy link

bcoe commented May 19, 2022

CC: @ChALkeR, @ronag, @BridgeAR, @danielleadams

Your votes would help break the deadlock 😄 and be greatly appreciated.

@mhdawson broke the deadlock.

@mhdawson
Copy link
Member

I don't want to stall this out any further and an willing to switch my vote. That will make it 8 for node:util. @Trott anything preventing me from changing my vote or with that can we consider it resolved?

@Trott
Copy link
Member

Trott commented May 19, 2022

I don't want to stall this out any further and an willing to switch my vote. That will make it 8 for node:util. @Trott anything preventing me from changing my vote or with that can we consider it resolved?

That would do it.

@aduh95 aduh95 requested a review from mhdawson May 19, 2022 21:50
@bcoe bcoe mentioned this pull request May 22, 2022
4 tasks
@mhdawson
Copy link
Member

Believe the vote is concluded and we can land this.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

votes/2022-05-18-0.json Outdated Show resolved Hide resolved
@mhdawson mhdawson merged commit 422e8db into main May 25, 2022
@aduh95 aduh95 deleted the vote-parseArgs-home-module branch May 25, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vote on namespace for args parser