coloring is broken

[richardlau]

#98 has broken coloring of changelog entries in a terminal.

e.g. with current v14.x-staging

expected (with changelog-maker@2.6.0)

It looks like the formatting is corrupting the ansi escape codes. Both @BethGriggs and I ran into this preparing the most recent releases and we had to manually remove the corrupted ansi when pasting into the changelogs.

I guess we could stripAnsi() before formatting but then we'd lose the coloring completely.

cc @Trott

[Trott]

Hopefully the fix is an options setting in remark-stringify or something simple like that...

[richardlau]

Could we move the formatting into commit-to-output.js?

changelog-maker/commit-to-output.js

Lines 74 to 91 in caeeabd

	function toStringMarkdown (data) {
	let s = ''
	s += `* \\[[\`${data.sha.substr(0, 10)}\`](${data.shaUrl})] - `
	s += (data.semver || []).length ? `**(${data.semver.join(', ').toUpperCase()})** ` : ''
	s += data.revert ? '***Revert*** "' : ''
	s += data.group ? `**${data.group}**: ` : ''
	s += cleanMarkdown(data.summary)
	s += data.revert ? '" ' : ' '
	s += data.author ? `(${data.author}) ` : ''
	s += data.pr ? `[${data.pr}](${data.prUrl})` : ''
	s = s.trim()
	return (data.semver && data.semver.length)
	? chalk.green(chalk.bold(s))
	: (data.group === 'doc'
	? chalk.grey(s)
	: s)
	}

I had a go but got really confused trying to call the asynchronous format from a sync function.

[Trott]

The text color doesn't end up in our changelogs, website release notes/announcements, or anywhere else as far as I can tell. Is that correct? It's just for the terminal output of the person running the command? If so, a simple workaround (at least temporarily) is to add the --simple flag.