Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo Items #1

Closed
6 tasks done
jasnell opened this issue Jul 23, 2015 · 0 comments
Closed
6 tasks done

Todo Items #1

jasnell opened this issue Jul 23, 2015 · 0 comments

Comments

@jasnell
Copy link
Member

jasnell commented Jul 23, 2015

  • Improve Reporting (may factor to use a test runner like mocha) this is going to be difficult until we have more consistency among module test output
  • If the npm module does not include tests, can we detect that and automatically "fail-over" to github
  • Make sure we're running properly on Windows
  • Make sure we're running properly on Linux
  • Can we simplify choices for known modules (e.g. lodash)
  • Verify that the -k|--hmac option is working correctly
@jasnell jasnell closed this as completed Jul 25, 2015
targos added a commit that referenced this issue Feb 19, 2017
@targos
refactor: enable strict mode and change var to const/let
449cf6c 
* refactor: use const for require calls and top level constants

Use let for variables that should be const but are mocked with
rewire in the tests.

* refactor: enable strict mode in all source files

* refactor: consistent require calls

- first call always just after 'use strict';
- sort alphabetically
- fix node/npm/local grouping in some files
- remove comments about grouping

* convert remaining vars to const or let (#1)

* enable strict ESLint rule

* enable no-var ESLint rule and convert remaining vars to let and const
@bengl bengl mentioned this issue Sep 20, 2017
Closed
@Trott Trott mentioned this issue Sep 24, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasnell