citgm CI jobs audit #741
Comments
|
I think I have never used these jobs |
|
Most of those jobs are used to test that V8 upgrades will not break the ABI. TBH if they are very far behind it might make sense for us to delete them and recreate the jobs when we need them again (if we do).
… On Jul 15, 2019, at 5:51 PM, Michaël Zasso ***@***.***> wrote:
I think I have never used these jobs
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub <#741?email_source=notifications&email_token=AADZYVZSRLQIQNCYKAYM44DP7TWNTA5CNFSM4IDYZN6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7CNLI#issuecomment-511583917>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADZYVZJACGH6GDI6DTFPCLP7TWNTANCNFSM4IDYZN6A>.
|
3 tasks
Trott
pushed a commit
to mhdawson/io.js
that referenced
this issue
Oct 2, 2019
Remove reference to job that is out of date, has not been run for a long time and likely does not work properly. Refs: nodejs/citgm#741
Trott
pushed a commit
to nodejs/node
that referenced
this issue
Oct 2, 2019
Remove reference to job that is out of date, has not been run for a long time and likely does not work properly. Refs: nodejs/citgm#741 PR-URL: #29774 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
I've disabled these in Jenkins with a description pointing back to this issue. |
BridgeAR
pushed a commit
to nodejs/node
that referenced
this issue
Oct 9, 2019
Remove reference to job that is out of date, has not been run for a long time and likely does not work properly. Refs: nodejs/citgm#741 PR-URL: #29774 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been helping out @mhdawson and @sam-github update the test jobs in the CI to add centos7 for PPC (nodejs/build#1705). I've done the two main CITGM jobs (citgm-smoker and citgm-smoker-nobuild) but have noticed there are several more jobs in https://ci.nodejs.org/view/Node.js-citgm/ and am wondering if these are still in-use:
These don't appear to have been updated in a long time and, for example, do not use the system selector script (https://github.com/nodejs/build/blob/master/jenkins/scripts/VersionSelectorScript.groovy) to determine which platforms to build/test on for a given Node.js version.
Does anyone know if the above jobs are still required? If so they probably need to be updated to work on Node.js master. If not we should archive/delete them.
cc @nodejs/citgm
The text was updated successfully, but these errors were encountered: