-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: re-add undici #982
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76 ☔ View full report in Codecov by Sentry. |
Failure from https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3334/nodes=rhel8-x64/
|
@nodejs/undici I need some help in making the tests less flaky so we can re-land this. |
I think you fixed connect-timeout? What tests are still flaky? |
Let's try again with v5.26.5. Fresh CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3337/ |
Full CITGM for undici https://ci.nodejs.org/job/citgm-smoker/3383/ (I'm not sure if I'm configuring it correctly) |
@RafaelGSS You used the wrong job. It should be https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/ |
Note this will fail due to the regression in Node v21.6.0 This fixes it but I'm not sure it's the right fix: nodejs/undici#2617 |
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/237/ (v18 and v20) The undici test suite appears too flaky to be in citgm in its current state. |
We need to revisit this. Another regression appeared in v21.7.0 and would have been caught by undici. |
IMHO this should never have been removed in the first place (I said as much multiple times). Let's land this even if it fails and refine. |
Checklist
npm test
passeshere