Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a note about DNS to the generic HTTP error message #259

Merged
merged 6 commits into from
Apr 29, 2023

Conversation

SpencerKaiser
Copy link
Contributor

Fixes #257

sources/httpUtils.ts Outdated Show resolved Hide resolved
@SpencerKaiser
Copy link
Contributor Author

SpencerKaiser commented Apr 27, 2023

Updated error after latest push:

Internal Error: Error when performing the request to https://registry.yarnpkg.com/yarn/-/yarn-1.3.1.tgz; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting
    at ClientRequest.<anonymous> (/Users/skaiser/Dev/corepack/dist/corepack.js:43961:9)
    at ClientRequest.emit (node:events:513:28)
    at TLSSocket.socketErrorListener (node:_http_client:502:9)
    at TLSSocket.emit (node:events:513:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

and to repro this locally, override your machine's DNS server to be 1.2.3.4.5.6

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits. Can we remove the unrelated changes? We can take them to a separate PR if you want.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SpencerKaiser
Copy link
Contributor Author

@aduh95 done! Sorry; I was just worried the CI would fail but it looks like there isn't an action for that 😬 I'll go open an issue

@aduh95 aduh95 merged commit aa3cbdb into nodejs:main Apr 29, 2023
10 checks passed
@SpencerKaiser SpencerKaiser deleted the dns-error-suggestion branch May 1, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhelpful error when using yarn when system is unable to resolve package domains via DNS
2 participants