Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node builds bundle npm and corepack together #74

Closed
ambasta opened this issue Dec 2, 2021 · 1 comment
Closed

Node builds bundle npm and corepack together #74

ambasta opened this issue Dec 2, 2021 · 1 comment

Comments

@ambasta
Copy link

ambasta commented Dec 2, 2021

Currently, corepack sits behind node_install_npm in node/tools/install.py

  if 'true' == variables.get('node_install_npm'):
    npm_files(action)
    corepack_files(action)

'node_install_npmis in turn set bynode/configure.py`

parser.add_argument('--without-npm',
    action='store_true',
    dest='without_npm',
    default=None,
    help='do not install the bundled npm (package manager)')
...
  o['variables']['node_install_npm'] = b(not options.without_npm)

This has the side-effect that when node is built w/o npm (configure.py --without-npm), then corepack is deselected as well. Ideally, corepack should sit behind its own configure flag (configure.py --without-corepack) instead.

@aduh95
Copy link
Contributor

aduh95 commented Dec 5, 2021

Fixed by nodejs/node#41060.

/cc @arcanis

@aduh95 aduh95 closed this as completed Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants