Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

On requiring test cases for all bug fixes #40

Closed
orangemocha opened this issue Apr 9, 2015 · 3 comments · Fixed by #46
Closed

On requiring test cases for all bug fixes #40

orangemocha opened this issue Apr 9, 2015 · 3 comments · Fixed by #46

Comments

@orangemocha
Copy link

All Pull Requests that either fix bugs or introduce new functionality require at least one test case demonstrating the defect or validating the intended functionality. For bug fixes, the test should fail before the change, and pass after the change.

In some cases, this might be a difficult task / the test case might be too large to fit into a unit test. We should leave some flexibility in this policy and clarify when a bug fix can be taken without a test case.

@srl295
Copy link
Member

srl295 commented Apr 9, 2015

@orangemocha glad I hit reload before filing a dup. 👍
Perhaps something such as:

In exceptional cases, such as environments or failure modes difficult to reproduce, a detailed testing
description may be accepted in lieu of a specific test.

@Fishrock123
Copy link
Member

Here's an example, for posterity: nodejs/node@c9207f7

@orangemocha
Copy link
Author

Memory leaks are another good example.

jasnell added a commit that referenced this issue Apr 9, 2015
Makes allowance for cases where a specific test case may be difficult.

Fixes: #40
@jasnell jasnell closed this as completed Apr 9, 2015
dreamhigh0525 pushed a commit to dreamhigh0525/dev-policy that referenced this issue Mar 9, 2023
Makes allowance for cases where a specific test case may be difficult.

Fixes: nodejs/dev-policy#40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants