This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
doc: additional notes and edits #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few minor additional notes and style edits
|
|
||
| ## Notes | ||
|
|
||
| 1. The existing Node.js Workflow (https://nodejs.org/documentation/workflow/) contains the notion of "Milestones" (https://nodejs.org/documentation/workflow/#index_md_flexible_workflow_only_two_strict_rules). These are essentially Long Term Support Release targets used as goalposts for landing specific edits. The "LTS Candidate" process described in the Long Term Release section above would largely replace the Milestone mechanism. When the LTS WG declares that a particular Major.Minor release is an LTS Candidate, a tag should be created identifying it as such. The PR or Issue can then be tagged so that Issues or PR's that should be landed or closed before cutting the LTS Release can be tracked. |
There was a problem hiding this comment.
This seems fine, but they are also useful for majors.
a tag should be created identifying it as such.
Do you mean a tag or a milestone?
I'd prefer to use milestones for such, as they are closeable.
There was a problem hiding this comment.
Ah.. good catch. Meant to type Milestone
jasnell
added a commit
that referenced
this pull request
Apr 6, 2015
doc: additional notes and edits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor additional notes and style edits