This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
doc: clean up add tsc must review for semver-major bumps #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several minor clean ups and one significant addition: server-major bumps require TSC review.
| @@ -26,6 +26,8 @@ Before any Pull Request is landed, sufficient time should be given to receive in | |||
|
|
|||
| If it becomes apparent that the changes proposed by a given Pull Request: (a) have significant impact on the project as a whole; (b) are inherently controversial; or (c) have failed to reach consensus amongst Collaborators, the Pull Request can be elevated for review by either a specific Working Group (by attaching a WG specific tag to the PR) or the TSC (by attaching the *tsc-agenda* tag to the PR). Pull Requests that have been flagged for TSC or Working Group review must not be landed until the TSC or Working Group has had sufficient opportunity to review the issue and render a decision. A Working Group may choose to defer the issue to the TSC. | |||
|
|
|||
| Pull Requests that require an increase in the Major version must be elevated for review by the TSC. | |||
There was a problem hiding this comment.
Maybe a little more language about this would be helpful, usually it isn't worthwhile to raise anything to the TC (at least in a meeting) immediately.
|
@Fishrock123 ... better? |
jasnell
added a commit
that referenced
this pull request
Apr 6, 2015
doc: clean up add tsc must review for semver-major bumps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor clean ups and one significant addition: server-major
bumps require TSC review.