Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-arch support for alpine #568

Closed
mikesir87 opened this issue Nov 1, 2017 · 4 comments
Closed

Add multi-arch support for alpine #568

mikesir87 opened this issue Nov 1, 2017 · 4 comments

Comments

@mikesir87
Copy link
Contributor

Now that alpine is supporting multi-arch, it'd be great to have multi-arch support for all node:alpine variants.

I'm willing to put in a PR, but from what I can tell, we only need to update the node file in the official-images here and add the other architectures. Shouldn't everything else just fall into place from there? 🤔

@tianon
Copy link
Contributor

tianon commented Nov 1, 2017

I believe that the generate-stackbrew-library.sh script here needs https://github.com/nodejs/docker-node/blob/master/architectures to be updated to include alpine in more lines.

@mikesir87
Copy link
Contributor Author

Gotcha. Is there any good way to test the updates, other than just running it through the pipeline?

@SimenB
Copy link
Member

SimenB commented Nov 1, 2017

Yes, should be enough to update that file.

mikesir87 added a commit to mikesir87/docker-node that referenced this issue Nov 1, 2017
@mikesir87
Copy link
Contributor Author

Ok. File changed and PR submitted. 👍

mikesir87 added a commit to mikesir87/docker-node that referenced this issue Nov 1, 2017
mikesir87 added a commit to mikesir87/docker-node that referenced this issue Nov 1, 2017
mikesir87 added a commit to mikesir87/docker-node that referenced this issue Nov 1, 2017
SimenB pushed a commit that referenced this issue Nov 1, 2017
* Add alpine to multi-arch support

Issue #568

* Updated architectures for 4.8 to include alpine

Issue #568

* Removed alpine multi-arch for 4.8 and 6.11 and arm32v6 support

Issue #568

* Restored alpine to amd64 architecture

Issue #568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants