Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.js v16 from 16.3.0 to 16.4.0 #1502

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Conversation

BenjD90
Copy link
Contributor

@BenjD90 BenjD90 commented Jun 24, 2021

Description

Update node.js v16 from 16.3.0 to 16.4.0

Reference:

Motivation and Context

New version released

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

⚠️ The checksum are empty in the new Dockerfiles due to missing files in https://unofficial-builds.nodejs.org/download/release/v16.4.0/ The seams to have stopped while it was running https://unofficial-builds.nodejs.org/logs/202106231214-v16.4.0/build.log

@BenjD90 BenjD90 marked this pull request as ready for review June 24, 2021 09:26
@SimenB
Copy link
Member

SimenB commented Jun 24, 2021

I assume it failed due to the key server issues: https://unofficial-builds.nodejs.org/logs/202106231214-v16.4.0/fetch-source.log

@rvagg any idea when builds will be available?

@rvagg
Copy link
Member

rvagg commented Jun 24, 2021

manually requested another build https://unofficial-builds.nodejs.org/logs/202106241124-v16.4.0/

hopefully we can get rid of this particular flaky step of the build soon: nodejs/admin#456

@BenjD90
Copy link
Contributor Author

BenjD90 commented Jun 24, 2021

@rvagg It worked 😄

Waiting workflows to run.

@BenjD90
Copy link
Contributor Author

BenjD90 commented Jun 24, 2021

Any help is welcome, I'm not used to build those images.
The error is very not clear to me 😕

failed to solve: rpc error: code = Unknown desc = executor failed running

@nschonni
Copy link
Member

Failures are because of #1500

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

Created PR on the official-images repo (docker-library/official-images#10480). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants