Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop arm32v7 buster for Node 20 #1886

Merged
merged 1 commit into from Apr 22, 2024
Merged

Conversation

nschonni
Copy link
Member

Description

Need to confirm that this is required in #1885 so opening as draft for now

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@richardlau
Copy link
Member

I replied in #1885 (comment) -- Node.js 20 should be okay in a standard Debian Buster container on all platforms except for armv7l.

FWIW It is possible to run the Node.js 20 armv7l binaries in the 10-buster image from https://hub.docker.com/r/arm32v7/gcc.

@yosifkit
Copy link
Contributor

With that information, I'd vote to only drop arm32v7 from the Node.js 20 images on buster.

On the other hand, the next stable release of Debian is "soon" (bookworm is currently at the "Hard Freeze" stage) so maybe fully dropping buster on 20.x and only doing the two most-recent Debian releases would be better (one until the Bookworm release). 🤔 🤷

buster is currently under "Debian LTS", so it already has a constrained set of architectures.

@nschonni nschonni changed the title feat: drop buster for Node 20 feat: drop arm34v7 buster for Node 20 Apr 25, 2023
@nschonni nschonni marked this pull request as ready for review April 25, 2023 01:35
@nschonni
Copy link
Member Author

I've updated it to just drop the arm32v7 instead of fully dropping buster

@richardlau
Copy link
Member

FWIW the commit message has a typo, "arm34v7" instead of "arm32v7".

@nschonni nschonni changed the title feat: drop arm34v7 buster for Node 20 feat: drop arm32v7 buster for Node 20 Apr 25, 2023
@nschonni
Copy link
Member Author

FWIW the commit message has a typo, "arm34v7" instead of "arm32v7".

Thanks, fixed

@SimenB
Copy link
Member

SimenB commented Sep 8, 2023

Is this waiting on anything in particular?

@joshuawwright
Copy link

joshuawwright commented Apr 19, 2024

@SimenB Any chance this will get merged? As it stands the arm32v7/node docker image can't be used :(

@SimenB
Copy link
Member

SimenB commented Apr 22, 2024

@nschonni is it good to go?

@nschonni nschonni merged commit 1fc16c3 into nodejs:main Apr 22, 2024
1 check passed
@nschonni nschonni deleted the buster-node-20 branch April 22, 2024 19:33
Copy link

Created PR on the official-images repo (docker-library/official-images#16641). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants