Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credentials.json is currently ignored in iojs.org folder #221

Closed
wants to merge 1 commit into from

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Jul 11, 2023

currently the credentials are stored in iojs.org/credentials.json. This prevent accidental commit them.

@UlisesGascon UlisesGascon changed the title fix: credentials.json is currently ignored in update folder fix: credentials.json is currently ignored in iojs.org folder Jul 11, 2023
@richardlau
Copy link
Member

That's odd -- the file is ignored for me without this change:

$ git rev-parse HEAD
1e1305a7b3d247e8c7335cb2182bb83273946a09
$ cat .gitignore
credentials.json
node_modules
$ git status --ignored
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        update/package-lock.json

Ignored files:
  (use "git add -f <file>..." to include in what will be committed)
        iojs.org/credentials.json
        update/node_modules/

nothing added to commit but untracked files present (use "git add" to track)
$

@Trott
Copy link
Member

Trott commented Jul 11, 2023

Confirming what Richard wrote. The entry as it exists now should ignore credentials.json in all subdirectories so this change shouldn't be necessary. The git docs confirm that foo and **/foo will give the same result in a .gitignore file.

@UlisesGascon
Copy link
Member Author

My fault, I made a mistake when I created the file name so that explains why the gitignore didn't act as I expected. Thanks for the review :)

@UlisesGascon UlisesGascon deleted the fix/gitignore branch July 11, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants