Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve yarn detection #29

Merged
merged 1 commit into from May 14, 2019
Merged

Improve yarn detection #29

merged 1 commit into from May 14, 2019

Conversation

osule
Copy link
Contributor

@osule osule commented Jan 15, 2019

Installing full-icu-npm in a yarn workspace fails.
The reason is because npmPath evaluates to cli.js and not yarn.js.

The test pattern is improved to match npmPath ending with yarn/*/cli.js
together with yarn.js

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2019

CLA assistant check
All committers have signed the CLA.

Installing full-icu-npm in a yarn workspace fails.
The reason is because npmPath evaluates to cli.js and not yarn.js.

The test pattern is improved to match npmPath ending with yarn/*/cli.js
together with yarn.js
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srl295 srl295 merged commit 9216975 into nodejs:master May 14, 2019
@srl295 srl295 added this to the v1.3.0 milestone May 14, 2019
@osule osule deleted the support-install-in-yarn-workspaces branch May 14, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants