Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path seperator #62

Closed
wants to merge 9 commits into from
Closed

Add path seperator #62

wants to merge 9 commits into from

Conversation

rtarsimi
Copy link
Contributor

This avoid permission issues for users that cannot create files in "/", like "/tmpXXXX". It will generate "/tmp/XXX" instead.

srl295 and others added 9 commits March 17, 2020 15:51
@srl295
wip
03d676e
@srl295
no package file
0eb146a
@srl295
move fetch out
3fe71ed
@srl295
wip yes actual test
c631563
@srl295
add .eslint
c700273
@srl295
some lint
652cffa
@srl295
travis and tests pass
bc903b4
@rtarsimi
Add path seperator
d696940 
This avoid permission issues for users that cannot create files in "/",  like "/tmpXXXX". It will generate "/tmp/XXX" instead.
@rtarsimi
Merge pull request #1 from rtarsimi/temporary-directory-fix
0a0e297 
Add path seperator
srl295
srl295 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@srl295 srl295 force-pushed the pull-l-from-gh branch 7 times, most recently from 3a0a45a to 0818c3f Compare September 24, 2021 22:47
srl295 added a commit that referenced this pull request Sep 27, 2021
@srl295
Add path seperator
47379f0 
This avoid permission issues for users that cannot create files in "/",  like "/tmpXXXX". It will generate "/tmp/XXX" instead.

Co-Authored-By: Rachid Tarsimi <rtarsimi@users.noreply.github.com>

d696940

From: #62
@srl295
Copy link
Member

srl295 commented Sep 27, 2021 •
edited
Loading

@rtarsimi I merged this into 9e09cff in #53 thanks

@srl295 srl295 closed this Sep 27, 2021
srl295 added a commit that referenced this pull request Sep 27, 2021
@srl295 @rtarsimi
Add path seperator
9e09cff 
This avoid permission issues for users that cannot create files in "/",  like "/tmpXXXX". It will generate "/tmp/XXX" instead.

Ref: #62 d696940
Co-authored-By: Rachid Tarsimi <rtarsimi@users.noreply.github.com>
srl295 added a commit that referenced this pull request Sep 30, 2021
@srl295 @rtarsimi
Add path seperator
f2c9c02 
This avoid permission issues for users that cannot create files in "/",  like "/tmpXXXX". It will generate "/tmp/XXX" instead.

Ref: #62 d696940
Co-authored-By: Rachid Tarsimi <rtarsimi@users.noreply.github.com>
srl295 added a commit that referenced this pull request Sep 30, 2021
@srl295 @rtarsimi
Add path seperator
4b0ee36 
This avoid permission issues for users that cannot create files in "/",  like "/tmpXXXX". It will generate "/tmp/XXX" instead.

Ref: #62 d696940
Co-authored-By: Rachid Tarsimi <rtarsimi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rtarsimi @srl295