Request: run full CI via label or comment

[cjihrig]

It looks like this has come up in the past (#82). I'm not 100% clear on what the resolution was, but it would be great if collaborators could add a label/comment to a PR to trigger a full CI run in Jenkins. I have a preference toward a label over a comment because a comment generates an email/notification, and issue labeling is restricted to trusted collaborators. This would imply the "Certify Safe" checkbox in Jenkins.

I think the following workflow would allow collaborators to avoid Jenkins completely in a lot of cases:

• A new PR is opened.
• Collaborator reviews the PR to certify its safety.
• Collaborator adds a specific label to the PR.
• Bot notices the label, removes the label, and starts a full CI run.
• Bot posts a comment to the PR containing the CI run URL.

[phillipj]

FWIW even though I'm not an active collaborator in core these days, I think this is a very good idea!

Kicking off full CI has certainly not been blocked technically, but rather the manual action of checking off the good old Certify Safe checkbox. In my eyes, a label would in practise have the exact same purpose; a very explicit signal that the changes doesn't look harmful and is ready to go.

Any thoughts what would be the next step to implementing this? Would it have to be discussed by TSC?

[cjihrig]

If it's not a technical issue, I think it should be fine to just ping @nodejs/tsc and @nodejs/build to see if there are any objections. If no one objects, I think it's fine to move forward.

[sam-github]

I would love to be able to trigger CI via github's UI, I am fine with a label or with a comment @nodebot full-ci please

[mmarchini]

I have a (unpublished) POC Firefox extension which adds a button to the PR to start CI. This would probably be a better solution though. I'll try to work on this, the extension works and the code should be mostly the same here.