Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failure when build directory contains spaces #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: failure when build directory contains spaces #204

wants to merge 1 commit into from

Commits on Oct 30, 2023

  1. fix: failure when build directory contains spaces 

    Fix an installation issue that occurs when a path in which node-gyp is
run contains spaces.

For a path like `my app`, it would error with this message:

```
clang: error: no such file or directory: 'app/node_modules/node-addon-api'
```

The "my" part before the space (and the rest of the path before it)
would be missing from the path in the error message.

Fixes nodejs/node-gyp#65
    @davej @tombruijn
    davej authored and tombruijn committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    87c51bf View commit details
    Browse the repository at this point in the history