Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failed to detect flavor if compiler path include white spaces #240

Merged
merged 12 commits into from
Apr 23, 2024
Merged

fix: failed to detect flavor if compiler path include white spaces #240

merged 12 commits into from
Apr 23, 2024

Commits on Apr 2, 2024

  1. fix: failed to detect flavor if compiler path include white spaces

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4c049a0 View commit details
    Browse the repository at this point in the history

  2. raise error if exit code is not 0

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b6b68d6 View commit details
    Browse the repository at this point in the history

  3. fix ruff lint

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    50fd4ca View commit details
    Browse the repository at this point in the history

  4. pipe stderr

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    432a6dd View commit details
    Browse the repository at this point in the history

  5. fix test

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    3781700 View commit details
    Browse the repository at this point in the history

  6. os.sep

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    3945b0d View commit details
    Browse the repository at this point in the history

  7. ruff --select=PT pylib/gyp/common_test.py

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    86a37ba View commit details
    Browse the repository at this point in the history

  8. use subprocess.run

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    3689451 View commit details
    Browse the repository at this point in the history

  9. ruff --select=SIM300 pylib/gyp/common_test.py

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1bae115 View commit details
    Browse the repository at this point in the history

  10. fix: emcc may print additional info at the first

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9e85fa3 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Christian Clauss <cclauss@me.com>
    @toyobayashi @cclauss
    toyobayashi and cclauss committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b0a7607 View commit details
    Browse the repository at this point in the history

  12. remove unused continue

    @toyobayashi
    toyobayashi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d03f52d View commit details
    Browse the repository at this point in the history