.flake8: max-complexity and ignore=C901 are mutually exclusive #54
Conversation
NOTE: max-complexity should be 10, not 101! I have never seen a complexity level so high. Also max-line-length and ignore=E501 are mutually exclusive. max-line-length should be 88, not 180.
| max-complexity = 10 | ||
| max-line-length = 88 | ||
| extend-ignore = E203,C901,E501 | ||
| max-complexity = 101 |
There was a problem hiding this comment.
NOTE: max-complexity should be 10, not 101! I have never seen a complexity level so high.
So now we need to refactor the code until this can be 10 again?
There was a problem hiding this comment.
A future work effort perhaps
| max-line-length = 88 | ||
| extend-ignore = E203,C901,E501 | ||
| max-complexity = 101 | ||
| max-line-length = 180 |
There was a problem hiding this comment.
This one should be pretty easy to fix, right? Can't we use black to enforce 88?
There was a problem hiding this comment.
Yes but black will not autofix all long lines. For example, lines that are in triple quoted strings.
There was a problem hiding this comment.
Ah, I remember @targos once mentioned that to me and I volunteered to fix it but didn't actually do it, so I guess that is my fault. I'll try to look into it again.
There was a problem hiding this comment.
Running black only reformats two files and only fixes 1 long line. This leaves 62 long lines that black will not fix.
These are nice tasks of first committers or interns.
NOTE: max-complexity should be 10, not 101! I have never seen a complexity level so high.
Also max-line-length and ignore=E501 are mutually exclusive. max-line-length should be 88, not 180.