-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs12: static assert fails on PPC: thread_local_top_ = 100 instead of 24 * pointer size #3972
Comments
Log for the reference: |
It seems there has been no activity on this issue for a while, and it is being closed in 30 days. If you believe this issue should remain open, please leave a comment. |
If anyone could help with some advice, it will be great. The issue is still relevant with the current version of NodeJS. |
CC @nodejs/v8 |
@RedYetiDev This could be macOS-specific in fact, I am not sure if size of these structures will be the same under ELF ABI. |
Thanks! I'll add the label back. |
Details
In
nodejs12
size ofThreadLocalTop
is defined as:Which for 32-bit system means 96. However when building for PPC, I get a bunch of static assert failures due to
thread_local_top_
being = 100: nodejs/node#30323 (comment) (yes, I checked that, adding an extra assert on its size explicitly).For w/e reason, in
nodejs16
the same place was changed to:And then, in current version, it is 26 and 25: https://github.com/nodejs/node/blob/main/deps/v8/src/execution/thread-local-top.h
Should I just change 24 to 25, so that assertion succeeds? Or do I have a bug with how
thread_local_top_
is calculated? If the latter is likely, any idea where to look?P. S. The context of why
nodejs12
: I am trying to fix it for Macports for MacOS PPC, and there is a branch ofnodejs12
supportingppc32
on AIX/Linux, so it should be feasible and likely easier to make it work. If it does, then I could try a newer version.Node.js version
12.22.12
Example code
No response
Operating system
MacOS 10.6.8 Server, GCC 12.2.0
Scope
Build
Module and version
Not applicable.
The text was updated successfully, but these errors were encountered: