Skip to content

Commit

Permalink
src: fix jslint errors
Browse files Browse the repository at this point in the history
PR-URL: #449
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
yosuke-furukawa authored and bnoordhuis committed Jan 15, 2015
1 parent 946eabd commit fd30eb2
Show file tree
Hide file tree
Showing 7 changed files with 91 additions and 91 deletions.
10 changes: 5 additions & 5 deletions lib/_debugger.js
Expand Up @@ -1269,11 +1269,11 @@ Interface.prototype.unwatch = function(expr) {

// List watchers
Interface.prototype.watchers = function() {
var self = this,
verbose = arguments[0] || false,
callback = arguments[1] || function() {},
waiting = this._watchers.length,
values = [];
var self = this;
var verbose = arguments[0] || false;
var callback = arguments[1] || function() {};
var waiting = this._watchers.length;
var values = [];

this.pause();

Expand Down
2 changes: 1 addition & 1 deletion lib/_http_client.js
Expand Up @@ -500,7 +500,7 @@ ClientRequest.prototype._deferToConnect = function(method, arguments_, cb) {
if (cb) { cb(); }
});
}
}
};
if (!self.socket) {
self.once('socket', onSocket);
} else {
Expand Down
148 changes: 74 additions & 74 deletions lib/events.js
Expand Up @@ -191,90 +191,90 @@ EventEmitter.prototype.once = function once(type, listener) {
// emits a 'removeListener' event iff the listener was removed
EventEmitter.prototype.removeListener =
function removeListener(type, listener) {
var list, position, length, i;

This comment has been minimized.

Copy link
@indutny

indutny Mar 24, 2015

Member

Oh, @bnoordhuis if only you knew my git blame pain because of this.

This comment has been minimized.

Copy link
@Fishrock123

Fishrock123 Mar 24, 2015

Member

look at the blame on github, you can just look at the parent commit to this XD

This comment has been minimized.

Copy link
@indutny

indutny Mar 24, 2015

Member

I'm not a web guy, not that much :)


if (!util.isFunction(listener))
throw TypeError('listener must be a function');

if (!this._events || !this._events[type])
return this;

list = this._events[type];
length = list.length;
position = -1;

if (list === listener ||
(util.isFunction(list.listener) && list.listener === listener)) {
delete this._events[type];
if (this._events.removeListener)
this.emit('removeListener', type, listener);

} else if (util.isObject(list)) {
for (i = length; i-- > 0;) {
if (list[i] === listener ||
(list[i].listener && list[i].listener === listener)) {
position = i;
break;
var list, position, length, i;

if (!util.isFunction(listener))
throw TypeError('listener must be a function');

if (!this._events || !this._events[type])
return this;

list = this._events[type];
length = list.length;
position = -1;

if (list === listener ||
(util.isFunction(list.listener) && list.listener === listener)) {
delete this._events[type];
if (this._events.removeListener)
this.emit('removeListener', type, listener);

} else if (util.isObject(list)) {
for (i = length; i-- > 0;) {
if (list[i] === listener ||
(list[i].listener && list[i].listener === listener)) {
position = i;
break;
}
}

if (position < 0)
return this;

if (list.length === 1) {
list.length = 0;
delete this._events[type];
} else {
spliceOne(list, position);
}

if (this._events.removeListener)
this.emit('removeListener', type, listener);
}
}

if (position < 0)
return this;

if (list.length === 1) {
list.length = 0;
delete this._events[type];
} else {
spliceOne(list, position);
}

if (this._events.removeListener)
this.emit('removeListener', type, listener);
}

return this;
};
};

EventEmitter.prototype.removeAllListeners =
function removeAllListeners(type) {
var key, listeners;

if (!this._events)
return this;

// not listening for removeListener, no need to emit
if (!this._events.removeListener) {
if (arguments.length === 0)
this._events = {};
else if (this._events[type])
delete this._events[type];
return this;
}
var key, listeners;

if (!this._events)
return this;

// not listening for removeListener, no need to emit
if (!this._events.removeListener) {
if (arguments.length === 0)
this._events = {};
else if (this._events[type])
delete this._events[type];
return this;
}

// emit removeListener for all listeners on all events
if (arguments.length === 0) {
for (key in this._events) {
if (key === 'removeListener') continue;
this.removeAllListeners(key);
}
this.removeAllListeners('removeListener');
this._events = {};
return this;
}
// emit removeListener for all listeners on all events
if (arguments.length === 0) {
for (key in this._events) {
if (key === 'removeListener') continue;
this.removeAllListeners(key);
}
this.removeAllListeners('removeListener');
this._events = {};
return this;
}

listeners = this._events[type];
listeners = this._events[type];

if (util.isFunction(listeners)) {
this.removeListener(type, listeners);
} else if (Array.isArray(listeners)) {
// LIFO order
while (listeners.length)
this.removeListener(type, listeners[listeners.length - 1]);
}
delete this._events[type];
if (util.isFunction(listeners)) {
this.removeListener(type, listeners);
} else if (Array.isArray(listeners)) {
// LIFO order
while (listeners.length)
this.removeListener(type, listeners[listeners.length - 1]);
}
delete this._events[type];

return this;
};
return this;
};

EventEmitter.prototype.listeners = function listeners(type) {
var ret;
Expand Down
2 changes: 1 addition & 1 deletion lib/repl.js
Expand Up @@ -398,7 +398,7 @@ function ArrayStream() {
data.forEach(function(line) {
self.emit('data', line + '\n');
});
}
};
}
util.inherits(ArrayStream, Stream);
ArrayStream.prototype.readable = true;
Expand Down
2 changes: 1 addition & 1 deletion lib/timers.js
Expand Up @@ -193,7 +193,7 @@ exports.setTimeout = function(callback, after) {
var args = Array.prototype.slice.call(arguments, 2);
timer._onTimeout = function() {
callback.apply(timer, args);
}
};
}

if (process.domain) timer.domain = process.domain;
Expand Down
4 changes: 2 additions & 2 deletions lib/util.js
Expand Up @@ -355,8 +355,8 @@ function formatPrimitive(ctx, value) {
return ctx.stylize('undefined', 'undefined');
if (isString(value)) {
var simple = '\'' + JSON.stringify(value).replace(/^"|"$/g, '')
.replace(/'/g, "\\'")
.replace(/\\"/g, '"') + '\'';
.replace(/'/g, "\\'")
.replace(/\\"/g, '"') + '\'';
return ctx.stylize(simple, 'string');
}
if (isNumber(value)) {
Expand Down
14 changes: 7 additions & 7 deletions src/node.js
Expand Up @@ -252,10 +252,10 @@

// strip the gyp comment line at the beginning
config = config.split('\n')
.slice(1)
.join('\n')
.replace(/"/g, '\\"')
.replace(/'/g, '"');
.slice(1)
.join('\n')
.replace(/"/g, '\\"')
.replace(/'/g, '"');

process.config = JSON.parse(config, function(key, value) {
if (value === 'true') return true;
Expand Down Expand Up @@ -773,15 +773,15 @@

NativeModule.getCached = function(id) {
return NativeModule._cache[id];
}
};

NativeModule.exists = function(id) {
return NativeModule._source.hasOwnProperty(id);
}
};

NativeModule.getSource = function(id) {
return NativeModule._source[id];
}
};

NativeModule.wrap = function(script) {
return NativeModule.wrapper[0] + script + NativeModule.wrapper[1];
Expand Down

0 comments on commit fd30eb2

Please sign in to comment.