test: double test timeouts on arm machines #1357
Conversation
|
cc @silverwind |
|
Build 444 on armv8 looks like it had the same amount of timeouts as this build's, fwiw. |
|
Is this the 30s test time limit? On which boards is it an issue? |
Yes. Specifically, the limit that makes tests fail with
The ARMv8 buildbot is the main offender and I noticed that's the one buildbot that seems unaffected by this change. I speculate that |
It does: |
|
The latest run suggests that the timeouts are persistent, doubling doesn't make a difference. I'm going to close this PR. |
|
Yeah, I wondered myself if that was really needed, as ARMv7 (RPi2) is almost fast enough to pass tests without any modifications. I expect ARMv8 to pass with our regular timeouts. |
|
I did some digging and I expect that libuv is to blame here, see libuv/libuv#308. |
The ARM buildbots are notoriously slow. Update the test runner to double the per-test time limit when it's running on one of them. PR-URL: nodejs#1357 Reviewed-By: Roman Reiss <me@silverwind.io>
|
@bnoordhuis ARMv6 seems to hit the 30s timeout on the following tests: That'd be two tests I can strike off my ARMv6 list if this gets merged. Would you reconsider this PR for these? |
|
Oh, sure. The branch still exists. If you LGTM it, I'll land it. |
|
LGTM. Just ran the ARMv6 tests with this patch, and no more |
bnoordhuis
force-pushed
the
arm-double-test-timeout
branch
from
5de6b66
to
3066f2c
Compare
The ARM buildbots are notoriously slow. Update the test runner to
double the per-test time limit when it's running on one of them.
R=@iojs/build
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/448/