update npm #1456
Closed
update npm #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Readme.md, as the subsequent npm update commit creates a README.md. Combining the create and delete operations into the same commit leads to OSX machines running into issues – they don't detect it as a rename, instead trying to create a new README.md, which fails because Readme.md hasn't been deleted yet. This causes the entire operation to fail spectacularly. Thus, the delete operation is performed first, in this commit, then the create operation follows in the npm update commit.
|
Seems fine to me. |
On Windows, when node or io.js attempts to dynamically load a compiled
addon, the compiled addon tries to load node.exe or iojs.exe again -
depending on which import library the module used when it was linked.
This causes many compiled addons to break when node.exe or iojs.exe are
renamed, because when the binary has been renamed the addon DLL can't
find the (right) .exe file to load its imports from.
This patch gives compiled addon developers an option to overcome this
restriction by compiling a delay-load hook into their binary. The
delay-load hook ensures that whenever a module tries to load imports
from node.exe/iojs.exe, it'll just look at the process image, thereby
making the addon work regardless of what name the node/iojs binary has.
To enable this feature, the addon developer must set the
'win_delay_load_hook' option to 'true' in their binding.gyp file, like
this:
```
{
'targets': [
{
'target_name': 'ernie',
'win_delay_load_hook': 'true',
...
```
Bug: #751
Bug: #965
Upstream PR: nodejs/node-gyp#599
PR-URL: #1251
Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #1266
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
chrisdickinson
added a commit
that referenced
this pull request
Apr 17, 2015
Remove Readme.md, as the subsequent npm update commit creates a README.md. Combining the create and delete operations into the same commit leads to OSX machines running into issues – they don't detect it as a rename, instead trying to create a new README.md, which fails because Readme.md hasn't been deleted yet. This causes the entire operation to fail spectacularly. Thus, the delete operation is performed first, in this commit, then the create operation follows in the npm update commit. PR-URL: #1456 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1448