Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: loosen infinite loop detect condition #1681

Closed
wants to merge 1 commit into from
Closed

test: loosen infinite loop detect condition #1681

wants to merge 1 commit into from

Conversation

yosuke-furukawa
Copy link
Member

related #1675

@brendanashworth brendanashworth added test Issues and PRs related to the tests. dgram Issues and PRs related to the dgram subsystem / UDP. labels May 12, 2015
@yosuke-furukawa
Copy link
Member Author

jenkins ci: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/663/

I don't have a permission to run jenkins ci. How do I get the permission??

@bnoordhuis
Copy link
Member

@rvagg Can you give @yosuke-furukawa access?

@yosuke-furukawa When you have an account, go here, fill in the 'user' and 'branch' fields ('yosuke-furukawa' and 'hotfix/test-dgram-send-callback-recursive' in this case), leave the other fields at their defaults, click 'Build' and go get a cup of coffee - you'll have plenty of time to finish it.

@yosuke-furukawa yosuke-furukawa changed the title test: loosen infinite detection condition test: loosen infinite loop detect condition May 12, 2015
@Fishrock123
Copy link
Member

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/664/

@Fishrock123
Copy link
Member

CI seems happier. The windows failures are unrelated afaik, I'll try to root them out today.

Fishrock123 pushed a commit that referenced this pull request May 14, 2015
@Fishrock123
test: fix infinite loop detection
4e2f999 
Fixes: #1675
PR-URL: #1681
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Member

Landed in 4e2f999 thanks!

@Fishrock123 Fishrock123 mentioned this pull request May 14, 2015
Merged
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 19, 2015
@Fishrock123
test: fix infinite loop detection
e7427ae 
Fixes: nodejs#1675
PR-URL: nodejs#1681
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yosuke-furukawa @bnoordhuis @Fishrock123 @brendanashworth