Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random test failures in test/parallel/test-dgram-send-callback-recursive.js #1675

Closed
evanlucas opened this issue May 11, 2015 · 5 comments
Closed
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Comments

@evanlucas
Copy link
Contributor

Introduced in PR #1313.

Seen on OS X.

Sometimes it will fail repeatedly and other times it will fail 1 out of 5.

/cc @yosuke-furukawa

@Fishrock123
Copy link
Member

x-post #1313 (comment)

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/657/nodes=osx1010/tapTestReport/test.tap-153/

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/657/nodes=win2012r2/tapTestReport/test.tap-153/

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/657/nodes=win2008r2/tapTestReport/test.tap-153/

not ok 153 - test-dgram-send-callback-recursive.js
# c:\workspace\iojs+any-pr+multi\nodes\win2012r2\test\parallel\test-dgram-send-callback-recursive.js:14
# throw new Error('infinite loop detected');
# ^
# Error: infinite loop detected
# at SendWrap.onsend [as callback] (c:\workspace\iojs+any-pr+multi\nodes\win2012r2\test\parallel\test-dgram-send-callback-recursive.js:14:11)
# at Immediate._onImmediate (dgram.js:342:10)
# at processImmediate [as _immediateCallback] (timers.js:368:17)

@mscdex mscdex added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels May 11, 2015
@yosuke-furukawa
Copy link
Member

OK, I will investigate it.

@yosuke-furukawa
Copy link
Member

OK I found the reason.
I just mistook the condition.
When io.js CPU load is heavy, the loop counter goes 10 higher like 11, but This counter limit is 10.
I should fix the condition. I will make pull request ASAP .

Thank you for notification.

Fishrock123 pushed a commit that referenced this issue May 14, 2015
Fixes: #1675
PR-URL: #1681
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Member

@evanlucas
Copy link
Contributor Author

Looks good to me :]

Fishrock123 pushed a commit to Fishrock123/node that referenced this issue May 19, 2015
Fixes: nodejs#1675
PR-URL: nodejs#1681
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants