crypto: add getCurves() to get supported ECs #1914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
the
semver-minor
|
👍 nice feature, will be pretty useful. Looking good from my side, though I can't review the C++ part. |
|
/cc @nodejs/crypto |
|
Looks like one of the Windows CI boxes has too little memory? |
| EC_builtin_curve* curves = | ||
| reinterpret_cast<EC_builtin_curve*>(malloc(sizeof(EC_builtin_curve) * len)); | ||
|
|
||
| if (curves) { |
There was a problem hiding this comment.
Won't this just fail silently if you run out of memory in the malloc call? Perhaps something like this would be simpler.
| Local<Array> arr = Array::New(env->isolate()); | ||
| size_t len = EC_get_builtin_curves(NULL, 0); | ||
| EC_builtin_curve* curves = | ||
| reinterpret_cast<EC_builtin_curve*>(malloc(sizeof(EC_builtin_curve) * len)); |
There was a problem hiding this comment.
Style: four spaces indent for line continuations and can you use sizeof(*curves)?
|
Commit updated as per suggestions. |
|
|
||
| if (num_curves) { | ||
| alloc_size = sizeof(*curves) * num_curves; | ||
| curves = reinterpret_cast<EC_builtin_curve*>(malloc(alloc_size)); |
There was a problem hiding this comment.
Micro-nit: just static_cast is sufficient here.
|
LGTM with nits. |
mscdex
added a commit
that referenced
this pull request
Jun 8, 2015
PR-URL: #1914 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 38d1afc. |
|
May as well update the doc change in deb8b87 again to point to this method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.