Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add references to crypto.getCurves() #1918

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

This adds references to the newly available crypto.getCurves (#1914) method where appropriate. I kept the openssl bits as it gives a bit more detail about the curves.

cc: @mscdex

@silverwind silverwind added the doc Issues and PRs related to the documentations. label Jun 8, 2015
@@ -814,6 +815,7 @@ The numeric representation of the local port.
[Chrome's 'modern cryptography' setting]: http://www.chromium.org/Home/chromium-security/education/tls#TOC-Deprecation-of-TLS-Features-Algorithms-in-Chrome
[specific attacks affecting larger AES key sizes]: https://www.schneier.com/blog/archives/2009/07/another_new_aes.html
[BEAST attacks]: http://blog.ivanristic.com/2011/10/mitigating-the-beast-attack-on-tls.html
[crypto.getCurves()]: #crypto_crypto_getcurves
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link won't work as-is since getCurves() is in a different document. I think it needs to be crypto.html#crypto_crypto_getcurves

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks. Wasn't sure about those links.

@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Jun 8, 2015
This adds references to the newly available crypto.getCurves method
where appropriate.
@silverwind
Copy link
Contributor Author

Updated that link

@mscdex
Copy link
Contributor

mscdex commented Jun 8, 2015

LGTM

silverwind added a commit that referenced this pull request Jun 9, 2015
This adds references to the newly available crypto.getCurves method
where appropriate.

PR-URL: #1918
Reviewed-By: Brian White <mscdex@mscdex.net>
@silverwind
Copy link
Contributor Author

Thanks, landed in 9f3a03f

@silverwind silverwind closed this Jun 9, 2015
@rvagg rvagg mentioned this pull request Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants