Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build shared llhttp #52

Closed
dilyanpalauzov opened this issue Mar 8, 2020 · 1 comment
Closed

Build shared llhttp #52

dilyanpalauzov opened this issue Mar 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@dilyanpalauzov
Copy link

Provided that node can be build with --shared-http-parser and the latter means shared llhttp, it must be possible to build shared libllhttp.so. Calling make install within llhttp`s source tree installs only static libraries.
@indutny
Copy link
Member

indutny commented Jul 8, 2020

This would be a great feature to have indeed! Sorry for delayed response.

@indutny indutny added the enhancement New feature or request label Jul 8, 2020
pallas added a commit to pallas/llhttp that referenced this issue Jan 13, 2021
@pallas
makefile: build & install shared library
9016398 
Note that the objects must be built with -fPIC now.  Tested with both clang
and gcc.

Issue: nodejs#52
@pallas pallas mentioned this issue Jan 13, 2021
Merged
indutny pushed a commit that referenced this issue Jan 29, 2021
@pallas
makefile: build & install shared library (#84)
aa07189 
Note that the objects must be built with -fPIC now.  Tested with both clang
and gcc.

Issue: #52
PR-URL: #84
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@indutny indutny closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indutny @dilyanpalauzov