Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lenient flag to make CR completely optional. #243

Merged
merged 2 commits into from
Sep 12, 2023
Merged

New lenient flag to make CR completely optional. #243

merged 2 commits into from
Sep 12, 2023

Conversation

ShogunPanda
Copy link
Contributor

@ShogunPanda ShogunPanda commented Sep 11, 2023 •
edited
Loading

Fixes #241 and #242.

@ShogunPanda ShogunPanda mentioned this pull request Sep 11, 2023
Closed
mcollina
mcollina approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda ShogunPanda merged commit 50524c0 into nodejs:main Sep 12, 2023
7 checks passed
@ShogunPanda ShogunPanda deleted the various branch September 12, 2023 07:51
@ShogunPanda ShogunPanda mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with on_body callback with bare LF
2 participants
@ShogunPanda @mcollina