Add aiohttp regression tests to CI #250
Conversation
|
I'm testing within the fork. It almost works, but fails to import the compiled parser for some reason. Will get back when it's fixed. |
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
|
@ShogunPanda OK, that's ready to go and can be merged in now. The 100_continue test failures are #249. The other test failure is just due to the wording of an error message being changed. I'll update that final test when we have a new release that fixes the other 2 tests. |
|
@Dreamsorcerer This looks go to me. Once aiohttp is all green with llhttp I'll merge this. |
|
Well, if you merge it first, then you should see the tests pass once #249 is fixed. We need the regression resolved before we can push a new release. |
@ShogunPanda The issue is on |
|
@benz0li @Dreamsorcerer I get a failure on llhttp CI. Can you please verify it? |
@ShogunPanda If you are talking about https://github.com/nodejs/llhttp/actions/runs/6225384656/job/16918217042?pr=250:
This needs to be fixed on |
|
@Dreamsorcerer @ShogunPanda Apparently you both disagree about which side is causing the problem. Please clarify this as soon as possible. Thank you. |
|
Yes, as mentioned above, the 100_continue failures: They are caused by #249, so if you merge this in now, you can use the CI to verify any fixes to that issue (i.e. you'll see those 2 failures disappear in the PR that fixes it).. |
|
@indutny As the initiator of |
|
Released v9.1.3. |
|
@ShogunPanda Thanks a lot. That's merged now, so if you rerun the last test run on master, then it should go green now: |
No description provided.