src: don't crash on invalid script positions #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "fixes" the crash reported in nodejs#422, in the sense that you no longer get a crash. However the printing does not actually work, i.e. you currently get an error like this: ```console (lldb) v8 i -s 0x2196b1a09a29 error: Invalid source range, start_pos=3108, len=-3098, source_len=10 ``` I'm deeming this better than crashing. We should really never be crashing as the coredump might be incomplete/partially corrupted. (Also, we already know function printing on v16 doesn't work right now.)
Codecov ReportBase: 73.65% // Head: 73.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 73.65% 73.59% -0.06%
==========================================
Files 34 34
Lines 4995 4999 +4
==========================================
Hits 3679 3679
- Misses 1316 1320 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks ^^ Definitely better than segfault. 😃 But we don't really know why that is happening. I'm correct? |
|
LGTM to so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fixes" the segfault reported in #422, in the sense that you no longer get a segfault. However the printing does not actually work, i.e. you currently get an error like this:
I'm deeming this better than segfaulting. We should really never be segfaulting as the coredump might be incomplete/partially corrupted. (Also, we already know function printing on v16 doesn't work right now.)