Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022-06-21 meeting #90

Merged
merged 1 commit into from
Jun 22, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 31 additions & 0 deletions doc/meetings/2022-06-21.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Node.js Loaders Team Meeting 2022-06-21

## Links

* **Recording**: https://www.youtube.com/watch?v=jh37GJZazz0
* **GitHub Issue**: https://github.com/nodejs/loaders/issues/88

## Present

* Loaders team: @nodejs/loaders
* Geoffrey Booth: @GeoffreyBooth
* Guy Bedford: @guybedford
* Bradley Farias: @bmeck
* Jacob Smith: @JakobJingleheimer

## Agenda

* https://github.com/nodejs/loaders/pull/89: Proposal for `preImport` hook

## Notes

Moving loaders off-thread might let us preserve an async `resolve` hook, with an `import.meta.resolve` that will appear to user code to be synchronous (can be called without `await`).

### Plan per today:

* Revert [the PR that changed our loader `resolve` hook and `import.meta.resolve` to become sync](https://github.com/nodejs/node/pull/43363), with a note that the PR will go back in if we discover that we can’t keep our async `resolve` hook with sync-looking `import.meta.resolve` via moving loaders off-thread. (Or if we discover that we can’t move loaders off-thread after all.)

* Close the [`preImport` PR](https://github.com/nodejs/node/pull/43245) for now, as we won’t need it if we can preserve the async `resolve`.

* Work on moving loaders off thread. Confirm that we _can_ keep the async `resolve` hook. If we succeed, we’re done and we can move on without reviving the old sync `resolve` and `preImport` PRs.