Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

re-enable issues tab on ecmascript-modules #212

Closed
devsnek opened this issue Oct 25, 2018 · 14 comments
Closed

re-enable issues tab on ecmascript-modules #212

devsnek opened this issue Oct 25, 2018 · 14 comments

Comments

@devsnek
Copy link
Member

devsnek commented Oct 25, 2018

I think people should report bugs and such with the concrete implementation in the repo where the concrete implementation resides. Is anyone opposed to re-enabling the issues tab on the ecmascript-modules repo?

@MylesBorins
Copy link
Contributor

We already have this repo... is there a distinction between opening an issue here and on ecmascript-modules?

@devsnek
Copy link
Member Author

devsnek commented Oct 25, 2018

@MylesBorins for us i would say the only thing is organization. in my head its easier to keep track of things as like "issues with our plans and movement" vs "technical issues with code"

it would also be less confusing for people who aren't part of this org, just trying to report issues they find with the implementation.

@MylesBorins
Copy link
Contributor

@devsnek if people outside this group are not going to be using the implementation in ecmascript-modules wouldn't it make more sense for their issues to be opened upstream on nodejs/node?

@jkrems
Copy link
Contributor

jkrems commented Oct 25, 2018

I can see where @devsnek is coming from. My biggest concern would be to keep track of the status of deeply technical issues as the implementation evolves. There's still the potential for some fundamental refactoring in the future. I'm -0 because having a 100% clear location to track everything (these issues) has merit in my eyes. Maybe a label is enough for now?

@GeoffreyBooth
Copy link
Member

In developing CoffeeScript 2 we had a “discuss” repo for planning and discussing features and that kind of thing, and the main CoffeeScript repo for actual development; and bugs were reported against the latter. I found it useful to have the two repos.

I think @devsnek’s suggestion makes sense, especially if we make it clear what the other repo’s issues are for, e.g. bugs with that implementation (but not general discussion or feature design/planning).

@SMotaal
Copy link

SMotaal commented Oct 26, 2018

Can I put some context here for @jkrems and @GeoffreyBooth because you may have not seen node/#23783 specifically this and the following comments.

We are running into a potential perspectives problem. For someone with an issues to file, the more repos they need to deal with, the harder it is for them to file an issue. It is not easy to figure out "ecmascript-modules" versus "modules" versus "node" let alone needing to actually understand the process of getting their own concerns through clearly.

It falls on us to make sure that we receive the right feedback, because every attempt, even if filed in the wrong repo (which sadly some projects look down upon) is hard to see from the perspective of someone not familiar with each projects ad-hoc structure.

@ljharb
Copy link
Member

ljharb commented Oct 26, 2018

Then it sounds like the solution is to rename the fork repo to more clearly indicate what it is?

@SMotaal
Copy link

SMotaal commented Nov 1, 2018

@ljharb what did you have in mind?

@ljharb
Copy link
Member

ljharb commented Nov 1, 2018

“experimental-ecmascript-modules-fork” or something else super verbose?

@GeoffreyBooth
Copy link
Member

“experimental-ecmascript-modules-new-implementation”?

@ljharb
Copy link
Member

ljharb commented Nov 1, 2018

That implies it's definitely the new implementation, which isn't necessarily the case.

@targos
Copy link
Member

targos commented Nov 24, 2018

We have setup a daily CI job that automatically updates the master and modules-lkgr branches: https://ci.nodejs.org/view/All/job/node-update-ecmascript-modules/

In case of failure, it can send an email to a list of individuals. I put @MylesBorins and my address. Anyone else would like to be notified?

@guybedford
Copy link
Contributor

Amazing work @targos! Please add me as well.

@targos
Copy link
Member

targos commented Nov 24, 2018

@guybedford done. I re-posted my message in the correct thread 😊

@devsnek devsnek removed the modules-agenda To be discussed in a meeting label Nov 24, 2018
@devsnek devsnek closed this as completed Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants