Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Document quorum required in order to merge PRs #26

Merged
merged 4 commits into from Feb 28, 2018

Conversation

@bmeck bmeck self-assigned this Feb 14, 2018
@WebReflection
Copy link
Member

WebReflection commented Feb 14, 2018

My only concern is that working on something and then not reaching the quorum after working, maybe a lot, might not be good to incentive contributions.

Could the possibility to reach the quorum upfront be also considered? I mean as a ticket with an issue/improvement instead of after the PR landed. Does this make any sense?

@bmeck
Copy link
Member Author

bmeck commented Feb 14, 2018

@WebReflection I think we could make an exception for bug fixes or editorial tweaks, but probably not a general case of approving a PR before the PR is finished.

@bmeck bmeck added modules-agenda To be discussed in a meeting governance labels Feb 14, 2018
@WebReflection
Copy link
Member

fair enough

benjamingr

This comment was marked as off-topic.

MylesBorins

This comment was marked as off-topic.

ljharb

This comment was marked as off-topic.

@bmeck
Copy link
Member Author

bmeck commented Feb 14, 2018

@ljharb since we talked about observers in the meeting and were noting that observers were not affecting quorum I assume they would not be counted.

@MylesBorins
Copy link
Member

@ljharb would you like to open a follow up PR defining Observer? If not I'm more than happy to take that on.

@MylesBorins MylesBorins added this to in progress in Governance Feb 15, 2018
@MylesBorins
Copy link
Member

Should we include a note about fast tracking doc fixes or errata?

@benjamingr
Copy link
Member

benjamingr commented Feb 15, 2018

I'm +1 on including said note - I don't think we should wait the "up to 2 weeks" for things that don't constitute of actual design decisions.

@giltayar
Copy link

LGTM

mcollina

This comment was marked as off-topic.

@manekinekko
Copy link

LGTM

manekinekko

This comment was marked as off-topic.

@bmeck
Copy link
Member Author

bmeck commented Feb 15, 2018

@MylesBorins @benjamingr I have added the errata and editorial exception.

benjamingr

This comment was marked as off-topic.

jasnell

This comment was marked as off-topic.

mhdawson

This comment was marked as off-topic.

@MylesBorins
Copy link
Member

@bmeck do you think we should move this into a CONTRIBUTING.md

MylesBorins

This comment was marked as off-topic.

MylesBorins added a commit that referenced this pull request Feb 18, 2018
As was discussed in the last meeting all members that did not fill out
the availability doodle have been moved to observer status.

Observers are not counted toward quorum and do not get to vote

Refs: #26
MylesBorins added a commit that referenced this pull request Feb 18, 2018
As was discussed in the last meeting all members that did not fill out
the availability doodle have been moved to observer status.

Observers are not counted toward quorum and do not get to vote

Refs: #8 (comment)
Refs: #26
@bmeck
Copy link
Member Author

bmeck commented Feb 19, 2018

@MylesBorins we can put it wherever, but it only is telling how members should act not how contributions should be made. I think a link might be better than moving this talk about how members act into a CONTRIBUTING document that focuses on how to makea PR. -0 to moving it, but +0 on linking from contributing guidelines.

targos

This comment was marked as off-topic.

@MylesBorins MylesBorins merged commit 98e6bf5 into nodejs:master Feb 28, 2018
@MylesBorins MylesBorins moved this from in progress to done in Governance Feb 28, 2018
@GeoffreyBooth GeoffreyBooth removed modules-agenda To be discussed in a meeting labels May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet