Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

governance: introduce PR exemptions for minutes #72

Merged
merged 2 commits into from May 9, 2018
Merged

governance: introduce PR exemptions for minutes #72

merged 2 commits into from May 9, 2018

Conversation

Fishrock123
Copy link
Member

@Fishrock123 Fishrock123 commented Apr 25, 2018 •
edited

This changes the special PR merging exemption for Errata and Editorial changes to be a general "Special Exemptions to the PR landing process", which has been updated to include meeting minutes & team updates via ncu-sync.

This is done so as to not consume time in meetings approving minutes.

This could be left for the next meeting. (PR Made during the meeting of April the 25th.)

@Fishrock123 Fishrock123 added modules-agenda To be discussed in a meeting governance labels Apr 25, 2018
devsnek

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

benjamingr

This comment was marked as off-topic.

Sign in to view

@benjamingr
Copy link
Member

Can we land this during the meeting rather than wait 2 weeks?

@Fishrock123
Copy link
Member Author

Sure, we may be able to bring it up at the end.

@Fishrock123
governance: introduce PR exemptions for minutes
64295e5 
This changes the special PR merging exemption for Errata and Editorial
changes to be a general "Special Exemptions to the PR landing process",
which has been updated to include meeting minutes.

This is done so as to not consume time in meetings approving minutes.

PR-URL: nodejs#72
Fishrock123 added a commit to Fishrock123/modules that referenced this pull request Apr 25, 2018
@Fishrock123
governance: add a PR exemption for ncu-sync
abcbb61 
Add updating the team lists in the readme via ncu-sync to the list of
special exemptions for landing PRs.

PR-URL: nodejs#72
ljharb

This comment was marked as off-topic.

Sign in to view

@ljharb
Copy link
Member

ljharb commented Apr 25, 2018

We already got approval at the beginning of the meeting to land this change; so i think this can already be considered mergeable.

@Fishrock123
Copy link
Member Author

@ljharb I don't think we got approval on this one? I made this halfway through the meeting.

targos

This comment was marked as off-topic.

Sign in to view

mcollina

This comment was marked as off-topic.

Sign in to view

inidaname

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

@Fishrock123
governance: add a PR exemption for ncu-sync
2e25000 
Add updating the team lists in the readme via ncu-sync to the list of
special exemptions for landing PRs.

PR-URL: nodejs#72
weswigham

This comment was marked as off-topic.

Sign in to view

jdalton

This comment was marked as off-topic.

Sign in to view

mhdawson

This comment was marked as off-topic.

Sign in to view

@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Closed
tbjers

This comment was marked as off-topic.

Sign in to view

linclark

This comment was marked as off-topic.

Sign in to view

iarna

This comment was marked as off-topic.

Sign in to view

bmeck

This comment was marked as off-topic.

Sign in to view

guybedford

This comment was marked as off-topic.

Sign in to view

xtuc

This comment was marked as off-topic.

Sign in to view

@jdalton jdalton merged commit ec4cb6a into nodejs:master May 9, 2018
@Fishrock123 Fishrock123 mentioned this pull request May 9, 2018
Merged
@GeoffreyBooth GeoffreyBooth removed modules-agenda To be discussed in a meeting labels May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jdalton jdalton jdalton approved these changes

@ljharb ljharb ljharb approved these changes

@mcollina mcollina mcollina approved these changes

@linclark linclark linclark approved these changes

@bmeck bmeck bmeck approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@guybedford guybedford guybedford approved these changes

@iarna iarna iarna approved these changes

@tbjers tbjers tbjers approved these changes

@benjamingr benjamingr benjamingr approved these changes

@xtuc xtuc xtuc approved these changes

@targos targos targos approved these changes

@weswigham weswigham weswigham approved these changes

@inidaname inidaname inidaname approved these changes

@devsnek devsnek devsnek approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
governance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet